From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Bernd Krumboeck <b.krumboeck@gmail.com>
Cc: linux-can@vger.kernel.org, linux-usb@vger.kernel.org,
info@gerhard-bertelsmann.de, gediminas@8devices.com,
Bernd Krumboeck <krumboeck@universalnet.at>
Subject: Re: [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices
Date: Sat, 15 Dec 2012 09:06:10 +0100 [thread overview]
Message-ID: <50CC2F72.60609@hartkopp.net> (raw)
In-Reply-To: <1355554434-10502-1-git-send-email-krumboeck@universalnet.at>
On 15.12.2012 07:53, Bernd Krumboeck wrote:
> +++ b/Documentation/ABI/testing/sysfs-driver-usb_8dev
> @@ -0,0 +1,13 @@
> +What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/firmware
> +Date: December 2012
> +Contact: Bernd Krumboeck <krumboeck@universalnet.at>
> +Description:
> + Returns the firmware version in the form "<major>.<minor>".
> + This file is readonly.
> +
> +What: /sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/hardware
> +Date: December 2012
> +Contact: Bernd Krumboeck <krumboeck@universalnet.at>
> +Description:
> + Returns the hardware version in the form "<major>.<minor>".
> + This file is readonly.
Hello Bernd,
sorry but probably i missed the discussion about this point:
Why do your create some extra sysfs entries for plain static information that
could be retrieved from the syslog too?
E.g. when attaching the PCAN USB, i get this:
usb 2-1.3: new full-speed USB device number 6 using ehci-pci
usb 2-1.3: New USB device found, idVendor=0c72, idProduct=000c
usb 2-1.3: New USB device strings: Mfr=0, Product=3, SerialNumber=0
usb 2-1.3: Product: VER1:PEAK
VER2:02.8.01
DAT :06.05.2004
TIME:09:35:37
...
peak_usb 2-1.3:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial FFFFFFFF (1 channel)
peak_usb 2-1.3:1.0 can2: attached to PCAN-USB channel 0 (device 67)
usbcore: registered new interface driver peak_usb
Don't you think it's a better idea to add an additional line to the syslog
telling about this *static* hw/sw information than adding the extra complexity
and documentation for the sysfs handling?
Regards,
Oliver
next prev parent reply other threads:[~2012-12-15 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 6:53 [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices Bernd Krumboeck
2012-12-15 8:06 ` Oliver Hartkopp [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-15 10:12 "Bernd Krumböck"
[not found] ` <525609baa6c4f07fdacc5089b7de5e4d.squirrel-2RFepEojUI0eLjVtqu/qlogRFKwBiOYo@public.gmane.org>
2012-12-15 12:01 ` Wolfgang Grandegger
2012-12-15 13:10 ` "Bernd Krumböck"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CC2F72.60609@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=b.krumboeck@gmail.com \
--cc=gediminas@8devices.com \
--cc=info@gerhard-bertelsmann.de \
--cc=krumboeck@universalnet.at \
--cc=linux-can@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).