Re: j1939 - first steps

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2100 bytes --]

On 03/20/2013 08:24 PM, Kurt Van Dijck wrote:
> On Tue, Mar 19, 2013 at 07:52:03AM +0100, Oliver Hartkopp wrote:
>> On 18.03.2013 22:41, Kurt Van Dijck wrote:
>>
>>> On Mon, Mar 18, 2013 at 09:13:33PM +0100, Oliver Hartkopp wrote:
>>
>>
>>>> And this (as user):
>>>>
>>>> ./jsr -v vcan0:0x22
>>> you should use 'vcan0:,0x22'.
>>> The format is: 'IFACE:<NAME>[,<ADDR>]'
>>>
>>
>>
>> ./jsr -?
>> jsr: An SAE J1939 send/recv utility
>> Usage: jsr [OPTION...] SOURCE [DEST]
>>
>>   -v, --verbose		Increase verbosity
>>   -p, --priority=VAL	J1939 priority (0..7, default 6)
>>   -S, --serialize	Strictly serialize outgoing packets
>>   -s, --size		Packet size, default autodetected
>>
>>   SOURCE	[IFACE:][NAME|SA][,PGN]
>>   DEST			[NAME|SA]
>>
>> Tells me something else ;-)
> 
> Oliver, how about this change in the docs.
> Would that have avoided this confusion (on both sides).
> 
> diff --git a/jacd.c b/jacd.c
> index 1358918..088b72c 100644
> --- a/jacd.c
> +++ b/jacd.c
> @@ -39,7 +39,8 @@ static const char help_msg[] =
>  	"NAME is the 64bit nodename" "\n"
>  	"\n"
>  	"Example:" "\n"
> -	"jacd -r 100,80-120 -c /tmp/1122334455667788.jacd 1122334455667788" "\n"
> +	"	$ jacd -r 100,80-120 -c /tmp/0123456789abcdef.jacd"
> +			" 0123456789abcdef" "\n"
>  	;
>  
>  #ifdef _GNU_SOURCE
> diff --git a/jspy.c b/jspy.c
> index b48fea1..6b7a215 100644
> --- a/jspy.c
> +++ b/jspy.c
> @@ -37,6 +37,10 @@ static const char help_msg[] =
>  	"			(= receive traffic not for this ECU)" "\n"
>  	"  -b, --block=SIZE	Use a receive buffer of SIZE (default 1024)" "\n"
>  	"  -t, --time[=a|d|z|A]	Show time: (a)bsolute, (d)elta, (z)ero, (A)bsolute w date" "\n"
> +	"\n"
> +	"	NAME, SA & PGN are in hex, without 0x prefix.\n"

What do you use to parse these numbers?

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]