From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Kurt Van Dijck <kurt.van.dijck@eia.be>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: j1939 - mainline problems
Date: Thu, 21 Mar 2013 07:47:54 +0100 [thread overview]
Message-ID: <514AAD1A.5030708@hartkopp.net> (raw)
In-Reply-To: <20130321060516.GB1419@vandijck-laurijssen.be>
On 21.03.2013 07:05, Kurt Van Dijck wrote:
> On Mon, Mar 18, 2013 at 10:31:25PM +0100, Oliver Hartkopp wrote:
>> Hi Kurt,
>>
>
>> E.g. why don't you add a j1939_priv pointer to struct dev_rcv_lists when
>> CONFIG_CAN_J1939 is enabled?
>
> This would allow to lookup a j1939_priv struct from a netdev directly.
> That is a great idea!
> I had not thought about that yet. Partly because I did start out-of-tree :-)
>
> I'll just go in that direction.
> Btw, It would be a struct j1939_segment * currently.
> I consider
> s/j1939_segment/j1939_priv/g
> if that makes things more clear.
'priv' looks consistent from the af_can point of view, as it is a j1939
private structure attached to the generic CAN per-netdevice structure.
>>
>> Looks like j1939_segment_find() is a frequently used walkthrough function ...
>>
> Your idea of dev_rcv_lists solves that.
That's why i was pointing at this possibility :-)
Regards,
Oliver
prev parent reply other threads:[~2013-03-21 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 21:31 j1939 - mainline problems Oliver Hartkopp
2013-03-20 10:18 ` Kurt Van Dijck
2013-03-21 6:05 ` Kurt Van Dijck
2013-03-21 6:47 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514AAD1A.5030708@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=kurt.van.dijck@eia.be \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).