Re: drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unmap'

Re: drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unmap'

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On 03/27/2013 09:31 AM, Fengguang Wu wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
> head:   de55eb1d60d2ed0f1ba5e13226d91b3bfbe1c108
> commit: 2b61972b74219d21ef1e91178349bdb840357688 can: sja1000: add support for PEAK-System PCMCIA card
> date:   1 year, 1 month ago
> config: make ARCH=sh allyesconfig
> 
> All error/warnings:
> 
>    In file included from drivers/net/can/sja1000/peak_pcmcia.c:28:0:
>    drivers/net/can/sja1000/sja1000.h:59:0: warning: "REG_SR" redefined [enabled by default]
>    arch/sh/include/asm/ptrace_32.h:25:0: note: this is the location of the previous definition

Another problem, a define conflict, due to missing namespace. I'm adding
a SJA1000_ to the sja1000 defines. I'll prepare a patch soon.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: drivers/net/can/sja1000/peak_pcmcia.c:626:2: error: implicit declaration of function 'ioport_unmap'

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

On 04/02/2013 09:47 AM, Stephane Grosjean wrote:
[...]

>>> This would no doubt be due to the defconfig selecting NO_IOPORT. This
>>> driver probably needs a HAS_IOPORT depends.
> 
>> Stephane, can we use pcmcia_map_mem_page() instead of ioport_map() like
>> in the ems_pcmcia driver?
>>
>> http://lxr.free-electrons.com/source/drivers/net/can/sja1000/ems_pcmcia.c#L286

> Ok, I'll have a look to that asap.

Fine.

> Meanwhile, adding the HAS_IOPORT depends in
> drivers/net/can/sja1000/Kconfig does the trick. What do you think about
> that?

Ack, done, already upstream :)

3fd3349 can: sja1000: limit PEAK PCAN-PC Card to HAS_IOPORT

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]