From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Wei Yongjun <weiyj.lk@gmail.com>, davem@davemloft.net
Cc: yongjun_wei@trendmicro.com.cn, linux-can@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] can: gw: use kmem_cache_free() instead of kfree()
Date: Tue, 09 Apr 2013 08:48:08 +0200 [thread overview]
Message-ID: <5163B9A8.2030306@hartkopp.net> (raw)
In-Reply-To: <CAPgLHd9eAfwJMJ9P5RqOKNP5kq87y61V7CTw2J--Ld8uHT0RrQ@mail.gmail.com>
On 09.04.2013 08:16, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> memory allocated by kmem_cache_alloc() should be freed using
> kmem_cache_free(), not kfree().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Oh yes, that's right ...
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Is also a stable candidate for Linux 3.2+ (can-gw emerged in 3.2)
Thanks for catching this!
Best regards,
Oliver
> ---
> net/can/gw.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/can/gw.c b/net/can/gw.c
> index 2d117dc..117814a 100644
> --- a/net/can/gw.c
> +++ b/net/can/gw.c
> @@ -466,7 +466,7 @@ static int cgw_notifier(struct notifier_block *nb,
> if (gwj->src.dev == dev || gwj->dst.dev == dev) {
> hlist_del(&gwj->list);
> cgw_unregister_filter(gwj);
> - kfree(gwj);
> + kmem_cache_free(cgw_cache, gwj);
> }
> }
> }
> @@ -864,7 +864,7 @@ static void cgw_remove_all_jobs(void)
> hlist_for_each_entry_safe(gwj, nx, &cgw_list, list) {
> hlist_del(&gwj->list);
> cgw_unregister_filter(gwj);
> - kfree(gwj);
> + kmem_cache_free(cgw_cache, gwj);
> }
> }
>
> @@ -920,7 +920,7 @@ static int cgw_remove_job(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
>
> hlist_del(&gwj->list);
> cgw_unregister_filter(gwj);
> - kfree(gwj);
> + kmem_cache_free(cgw_cache, gwj);
> err = 0;
> break;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-04-09 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 6:16 [PATCH] can: gw: use kmem_cache_free() instead of kfree() Wei Yongjun
2013-04-09 6:48 ` Oliver Hartkopp [this message]
2013-04-09 8:20 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2013-04-09 8:13 pull-request: can 2013-04-09 Marc Kleine-Budde
2013-04-09 8:13 ` [PATCH] can: gw: use kmem_cache_free() instead of kfree() Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5163B9A8.2030306@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox