linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Mylene Josserand <Mylene.Josserand@navocap.com>
Cc: linux-can@vger.kernel.org
Subject: Re: [imx27 - mcp251x] MCP251x does not work in static ?
Date: Thu, 11 Apr 2013 09:49:53 +0200	[thread overview]
Message-ID: <51666B21.10109@pengutronix.de> (raw)
In-Reply-To: <CA78C307B8F06747967D122FC656B15377445A@SERVEUR0.nvp.local>

[-- Attachment #1: Type: text/plain, Size: 3043 bytes --]

On 04/11/2013 09:39 AM, Mylene Josserand wrote:
> Hi Marc,
> 
> Le 10/04/2013 17:30, Marc Kleine-Budde a écrit :
>> On 04/10/2013 04:11 PM, Mylene Josserand wrote:
>>
>>>> If it's the first spi transfer in the driver that hangs and if the
>>>> mcp251x works if loaded as a module, there is probably some
>>>> initialisation missing. Look for stuff that gets initialized after the
>>>> mcp251x would have been loaded if compiled into the kernel. Make a
>>>> "diff" between the bootload with mcp251x compiled into the kernel and
>>>> without. Other usual suspects are: clocks, pinmux (spi _and_ the mcp251x
>>>> dedicated IRQ line), gpio setup.
>>>
>>> Thanks for the advice and the ideas to look at ! I have already compared
>>> the bootload and I have seen no differences (maybe I will check that
>>> another time). I will search about clocks, pinmux and gpio setup and I
>>> will update you if I found how to fix that.
>>
>> Save the bootlog of a system start with the driver compiled as a module
>> into file bootlog-module.txt. Make a second bootlog with the driver
>> compiled into the kernel, save as bootlog-builtin.txt. Then:
>>
>>      diff -u bootlog-module.txt bootlog-builtin.txt
>>
>> Look for the stuff that would have been initialized _after_ the system
>> hangs. The diff should show you this.
>>
>> Marc
>>
> 
> Thank you for the help.
> I have done it and instead of having the mcp configuration, in the 
> bootlog-module, there is the libphy fec_net_mii_bus driver probed and 
> other boot configurations.
> 
> "
>   spi_imx imx27-cspi.0: master is unqueued, this is deprecated
>   spi_imx imx27-cspi.0: probed
>   CAN device driver interface
> -mcp251x_can_init
> -mcp251x_clean
> -mcp251x_can_probe
> -mcp251x_hw_probe
> -mcp251x_hw_reset
> -mcp251x_hw_reset : spi_write : start
> +libphy: fec_enet_mii_bus: probed
> +PPP generic driver version 2.4.2
> +PPP BSD Compression module registered
> +PPP Deflate Compression module registered
> +PPP MPPE Compression module registered
> +ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
> +ehci-mxc: Freescale On-Chip EHCI Host driver
> +mxc-ehci mxc-ehci.2: initializing i.MX USB Controller
> [...]
> "
> 
> If the MCP 251x is compiled as module, will it use the init configuration ?
> 
> I think I have a problem with the irq because I have tried to use it as 
> module and when I do "ifconfig can0 up", I get :
> "
> root@navocap:~# ifconfig can0 up
> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 201
> mcp251x spi0.0: failed to acquire irq 201

It's a bug in the driver....which was introduced in v3.5[1]. I'm looking
for a fix.

Marc

[1] 1c6c695 genirq: Reject bogus threaded irq requests

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2013-04-11  7:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 13:07 [imx27 - mcp251x] MCP251x does not work in static ? Mylene Josserand
2013-04-10 13:39 ` Marc Kleine-Budde
2013-04-10 14:11   ` Mylene Josserand
2013-04-10 15:30     ` Marc Kleine-Budde
2013-04-11  7:39       ` Mylene Josserand
2013-04-11  7:49         ` Marc Kleine-Budde [this message]
2013-04-11  8:04           ` Mylene Josserand
2013-04-11  8:39             ` Marc Kleine-Budde
2013-04-11  9:22               ` Mylene Josserand
2013-04-11  9:49                 ` Marc Kleine-Budde
2013-04-11 14:39                   ` Mylene Josserand
2013-04-11 15:09                     ` Marc Kleine-Budde
2013-04-12  9:24                       ` Mylene Josserand
2013-04-12  9:49                         ` Marc Kleine-Budde
2013-04-12  9:36                     ` Marc Kleine-Budde
2013-04-12  9:40                       ` Mylene Josserand
2013-04-12  9:48                         ` Marc Kleine-Budde
2013-04-11  8:36           ` RFC: [PATCH] can: mcp251x: add missing IRQF_ONESHOT to request_threaded_irq Marc Kleine-Budde
2013-04-12 11:16             ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51666B21.10109@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=Mylene.Josserand@navocap.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).