Re: Usb to can driver

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On 04/24/2013 11:33 PM, Max S. wrote:
> From 8a83080bcddc558cd016e58e408b56ca68bc5bc8 Mon Sep 17 00:00:00 2001
> From: Maximilian Schneider <max@schneidersoft.net>
> Date: Wed, 24 Apr 2013 21:03:31 +0000
> Subject: [PATCH] Added ss_usb source.
> 
> 
> Signed-off-by: Maximilian Schneider <max@schneidersoft.net>

Please fix these errors, too:

> drivers/net/can/usb/ss_usb.c:343 ss_usb_set_bittiming() error: doing dma on the stack (&dbt)
> drivers/net/can/usb/ss_usb.c:374 ss_usb_set_mode() error: doing dma on the stack (&dm)
> drivers/net/can/usb/ss_usb.c:411 ss_usb_get_state() error: doing dma on the stack (&dstate)
> drivers/net/can/usb/ss_usb.c:465 ss_usb_get_berr_counter() error: doing dma on the stack (&dstate)
> drivers/net/can/usb/ss_usb.c:661 ss_can_open() error: doing dma on the stack (&dm)
> drivers/net/can/usb/ss_usb.c:736 ss_usb_probe() error: doing dma on the stack (&conf)
> drivers/net/can/usb/ss_usb.c:859 ss_make_candev() error: doing dma on the stack (&bt_const)

You should not use memory on stack for usb transfers. Use kmalloc(), or
kzalloc() (and kfree) instead.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]