Re: [PATCH 2/2] slcanpty: /dev/tty support for tests

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 10.06.2013 11:53, janusz.uzycki@elproma.com.pl wrote:
> Primarily I wanted to use stdin/stdout (defined as "-") but it required
> splitted p descriptor to pin and pout... For the "-" socat can be used so I
> stopped here.

:-)

Ok, which of your three patches do you suggest to be applied now?

Is the terminal flags update patch enough?

Best regards,
Oliver

> 
> best regards
> Janusz
> 
> W dniu 2013-06-10 11:44, janusz.uzycki@elproma.com.pl napisał(a):
>> From 4c6115b210b64cf93493c93b05f82c83a085fb73 Mon Sep 17 00:00:00 2001
>> From: Janusz Uzycki <j.uzycki@elproma.com.pl>
>> Date: Fri, 7 Jun 2013 23:02:13 +0200
>> Subject: [PATCH 2/2] slcanpty: /dev/tty support for tests
>>
>>
>> Signed-off-by: Janusz Uzycki <j.uzycki@elproma.com.pl>
>> ---
>>  slcanpty.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/slcanpty.c b/slcanpty.c
>> index f312362..b7e8ed7 100644
>> --- a/slcanpty.c
>> +++ b/slcanpty.c
>> @@ -44,6 +44,7 @@
>>  /* maximum rx buffer len: extended CAN frame with timestamp */
>>  #define SLC_MTU (sizeof("T1111222281122334455667788EA5F\r")+1)
>>  #define DEVICE_NAME_PTMX "/dev/ptmx"
>> +#define DEVICE_NAME_TTY "/dev/tty"
>>
>>  #define DEBUG
>>
>> @@ -407,10 +408,13 @@ int main(int argc, char **argv)
>>                         " /dev/ttyc0 for the slcan application\n", argv[0]);
>>                 fprintf(stderr, "e.g. for pseudo-terminal '%s %s can0' creates"
>>                         " /dev/pts/N\n", argv[0], DEVICE_NAME_PTMX);
>> +               fprintf(stderr, "e.g. for pseudo-terminal '%s %s can0' uses"
>> +                       " console terminal (for testing purposes)\n",
>> argv[0], DEVICE_NAME_TTY);
>>                 fprintf(stderr, "\n");
>>                 return 1;
>>         }
>>
>> +       if (strcmp(argv[1], DEVICE_NAME_TTY) != 0)
>>         select_stdin = check_select_stdin();
>>
>>         /* open pty */
>> -- 
>> 1.7.11.3