From: Oliver Hartkopp <socketcan@hartkopp.net>
To: janusz.uzycki@elproma.com.pl
Cc: linux-can@vger.kernel.org,
Krzysztof Borgulski <k.borgulski@elproma.com.pl>
Subject: Re: [PATCH 2/2] slcanpty: /dev/tty support for tests
Date: Tue, 11 Jun 2013 22:28:24 +0200 [thread overview]
Message-ID: <51B78868.2090301@hartkopp.net> (raw)
In-Reply-To: <f00a17de7fa15644f49ca035d77b1769@beep.pl>
On 10.06.2013 20:38, janusz.uzycki@elproma.com.pl wrote:
> ;)
>
> * The first today fixes terminal settings (cr/nl). Flags update is enough for
> that.
> * 1/2 patch introduces stdin detection switch. It is important if you want to
> use slcanpty as deamon - natural choice for me.
> * 2/2 patch is rather for very simple testings using console (like DEBUG
> define). However command "slcanpty /dev/tty vcan0 < /dev/null" makes the patch
> redundant.
> So the first and 1/2 are really strongly suggested.
Ok, i applied these two fixes after some coding style rework.
Tnx & best regards,
Oliver
next prev parent reply other threads:[~2013-06-11 20:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2DAB3DC2841347E7AF7833620339B427@laptop2>
2013-06-05 19:44 ` slcanpty Oliver Hartkopp
2013-06-06 12:03 ` slcanpty Janusz Uzycki
2013-06-06 18:31 ` slcanpty Oliver Hartkopp
2013-06-06 20:43 ` slcanpty janusz.uzycki
2013-06-07 13:40 ` [PATCH] slcanpty janusz.uzycki
2013-06-08 11:09 ` Oliver Hartkopp
2013-06-10 9:06 ` janusz.uzycki
2013-06-10 9:16 ` janusz.uzycki
2013-06-10 9:36 ` janusz.uzycki
2013-06-10 9:42 ` [PATCH 1/2] slcanpty: "slcanpty < /dev/null" issue fix janusz.uzycki
2013-06-10 9:44 ` [PATCH 2/2] slcanpty: /dev/tty support for tests janusz.uzycki
2013-06-10 9:53 ` janusz.uzycki
2013-06-10 18:29 ` Oliver Hartkopp
2013-06-10 18:38 ` janusz.uzycki
2013-06-11 20:28 ` Oliver Hartkopp [this message]
2013-06-11 16:29 ` slcanpty janusz.uzycki
2013-06-11 20:32 ` slcanpty Oliver Hartkopp
2013-06-11 21:19 ` slcanpty janusz.uzycki
2013-06-12 15:25 ` slcanpty Oliver Hartkopp
2013-06-14 8:42 ` slcanpty Janusz Uzycki
2013-06-18 8:24 ` slcanpty j.uzycki
2013-06-19 17:15 ` slcanpty Oliver Hartkopp
2013-06-19 22:39 ` slcanpty j.uzycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B78868.2090301@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=janusz.uzycki@elproma.com.pl \
--cc=k.borgulski@elproma.com.pl \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).