From: Bernd Krumboeck <krumboeck@universalnet.at>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: usb_8dev: unregister netdev before free()ing
Date: Tue, 18 Jun 2013 20:23:30 +0200 [thread overview]
Message-ID: <51C0A5A2.6010909@universalnet.at> (raw)
In-Reply-To: <1371560243-24316-1-git-send-email-mkl@pengutronix.de>
Am 2013-06-18 14:57, schrieb Marc Kleine-Budde:
> The usb_8dev hardware has problems on some xhci USB hosts. The driver fails to
> read the firmware revision in the probe function. This leads to the following
> Oops:
>
> [ 3356.635912] kernel BUG at net/core/dev.c:5701!
>
> The driver tries to free the netdev, which has already been registered, without
> unregistering it.
>
> This patch fixes the problem by unregistering the netdev in the error path.
>
Thank you for the patch!
I've applied it to my source tree:
https://github.com/krumboeck/usb2can
regards,
Bernd
next prev parent reply other threads:[~2013-06-18 18:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 12:57 [PATCH] can: usb_8dev: unregister netdev before free()ing Marc Kleine-Budde
2013-06-18 18:23 ` Bernd Krumboeck [this message]
2013-06-18 18:34 ` Marc Kleine-Budde
2013-06-18 20:20 ` Bernd Krumboeck
2013-06-18 20:21 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2013-06-19 7:02 pull-request: can 2013-06-19 Marc Kleine-Budde
2013-06-19 7:02 ` [PATCH] can: usb_8dev: unregister netdev before free()ing Marc Kleine-Budde
2013-06-19 16:29 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C0A5A2.6010909@universalnet.at \
--to=krumboeck@universalnet.at \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).