From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Bernd Krumboeck <krumboeck@universalnet.at>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: usb_8dev: unregister netdev before free()ing
Date: Tue, 18 Jun 2013 22:21:57 +0200 [thread overview]
Message-ID: <51C0C165.50901@pengutronix.de> (raw)
In-Reply-To: <51C0C11E.1090705@universalnet.at>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
On 06/18/2013 10:20 PM, Bernd Krumboeck wrote:
>>>> The driver tries to free the netdev, which has already been
>>>> registered, without
>>>> unregistering it.
>>>>
>>>> This patch fixes the problem by unregistering the netdev in the error
>>>> path.
>>>>
>>>
>>> Thank you for the patch!
>>>
>>> I've applied it to my source tree:
>>> https://github.com/krumboeck/usb2can
>>
>> Can I have you Acked-by or Reviewed-by?
>>
>> Marc
>>
>
> Yes, of course.
>
> Please add "Reviewed-by: Bernd Krumboeck <krumboeck@universalnet.at>".
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-06-18 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 12:57 [PATCH] can: usb_8dev: unregister netdev before free()ing Marc Kleine-Budde
2013-06-18 18:23 ` Bernd Krumboeck
2013-06-18 18:34 ` Marc Kleine-Budde
2013-06-18 20:20 ` Bernd Krumboeck
2013-06-18 20:21 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-19 7:02 pull-request: can 2013-06-19 Marc Kleine-Budde
2013-06-19 7:02 ` [PATCH] can: usb_8dev: unregister netdev before free()ing Marc Kleine-Budde
2013-06-19 16:29 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C0C165.50901@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=krumboeck@universalnet.at \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).