linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: j.uzycki@elproma.com.pl
Cc: linux-can@vger.kernel.org,
	Krzysztof Borgulski <k.borgulski@elproma.com.pl>
Subject: Re: slcanpty
Date: Wed, 19 Jun 2013 19:15:54 +0200	[thread overview]
Message-ID: <51C1E74A.70107@hartkopp.net> (raw)
In-Reply-To: <3dc287504f468fde2629107bdc65c4ae@beep.pl>

On 18.06.2013 10:24, j.uzycki@elproma.com.pl wrote:

>> BTW:
>> I've learnt about HW filters in SJA1000. I compared the datasheet
>> with acceptance filter explanation here
>> http://www.can232.com/?page_id=72
>> According to datasheet's figures filter output bit acceptance is
>> (AMRn | (input ^ ACCn)) and according to the tables in explanation
>> acceptance is (AMRn | !(input ^ ACCn)). Do you have experience in
>> practive about it?
>> I want to convert SJA1000 filter to SocetCAN. SJA1000 has several
>> difficult features: dual filter (problem with overlapped filters -
>> additional checking required), data filter for 1st and/or 2nd data
>> byte (BCM mode supports, RAW mode requires userland filtering but ok).
>> Finally I consider it is better to use socketCAN filters or implement
>> the whole well defined filter (not universal like socketcan filter) in
>> userland. What could be more CPU effective?
> 
> I've just implemented SJA1000 filter emulator. I didn't test it yet. What do
> you think about the idea?

Pretty funny.

Your referenced docs (and your patch) are very informative, but I just wonder
if the filters have really ever been used by anybody.

They look *very* special.

If there's a need to implement it, it's ok.
But IMHO adding the filters just for the completeness of an emulation can be
omitted when nobody is ever using it.

Best regards,
Oliver


  reply	other threads:[~2013-06-19 17:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2DAB3DC2841347E7AF7833620339B427@laptop2>
2013-06-05 19:44 ` slcanpty Oliver Hartkopp
2013-06-06 12:03   ` slcanpty Janusz Uzycki
2013-06-06 18:31     ` slcanpty Oliver Hartkopp
2013-06-06 20:43       ` slcanpty janusz.uzycki
2013-06-07 13:40       ` [PATCH] slcanpty janusz.uzycki
2013-06-08 11:09         ` Oliver Hartkopp
2013-06-10  9:06           ` janusz.uzycki
2013-06-10  9:16             ` janusz.uzycki
2013-06-10  9:36               ` janusz.uzycki
2013-06-10  9:42                 ` [PATCH 1/2] slcanpty: "slcanpty < /dev/null" issue fix janusz.uzycki
2013-06-10  9:44                   ` [PATCH 2/2] slcanpty: /dev/tty support for tests janusz.uzycki
2013-06-10  9:53                     ` janusz.uzycki
2013-06-10 18:29                       ` Oliver Hartkopp
2013-06-10 18:38                         ` janusz.uzycki
2013-06-11 20:28                           ` Oliver Hartkopp
2013-06-11 16:29       ` slcanpty janusz.uzycki
2013-06-11 20:32         ` slcanpty Oliver Hartkopp
2013-06-11 21:19           ` slcanpty janusz.uzycki
2013-06-12 15:25             ` slcanpty Oliver Hartkopp
2013-06-14  8:42               ` slcanpty Janusz Uzycki
2013-06-18  8:24               ` slcanpty j.uzycki
2013-06-19 17:15                 ` Oliver Hartkopp [this message]
2013-06-19 22:39                   ` slcanpty j.uzycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51C1E74A.70107@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=j.uzycki@elproma.com.pl \
    --cc=k.borgulski@elproma.com.pl \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).