From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Benedikt Spranger <b.spranger@linutronix.de>
Cc: netdev@vger.kernel.org,
Alexander Frank <Alexander.Frank@eberspaecher.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Holger Dengler <dengler@linutronix.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH 12/16] c_can: Add flag to disable automatic retransmission of CAN frames
Date: Mon, 09 Sep 2013 12:34:15 +0200 [thread overview]
Message-ID: <522DA427.2090008@pengutronix.de> (raw)
In-Reply-To: <522DA145.9090507@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On 09/09/2013 12:21 PM, Marc Kleine-Budde wrote:
> On 09/09/2013 09:25 AM, Benedikt Spranger wrote:
>> The C_CAN/D_CAN controler can automatic retransmit CAN after arbitration loss.
>> Add a flag to CAN ctrlmode set the appropiate behaivior of this feature.
>
> We already have this flag, it's called CAN_CTRLMODE_ONE_SHOT.
BTW: Have a look at commit:
ee6f098 can: c_can: disable one shot mode until driver is fixed
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-09-09 10:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1378711513-2548-1-git-send-email-b.spranger@linutronix.de>
2013-09-09 7:54 ` [PATCH 00/16] Support for Eberspächer Flexcard DCAN function Marc Kleine-Budde
[not found] ` <1378711513-2548-2-git-send-email-b.spranger@linutronix.de>
2013-09-09 8:22 ` [PATCH 01/16] c_can_platform: add FlexCard D-CAN support Marc Kleine-Budde
[not found] ` <1378711513-2548-3-git-send-email-b.spranger@linutronix.de>
2013-09-09 8:34 ` [PATCH 02/16] c_can: add generic D-CAN RAM initialization support Marc Kleine-Budde
[not found] ` <1378711513-2548-4-git-send-email-b.spranger@linutronix.de>
2013-09-09 9:16 ` [PATCH 03/16] c_can: simplify arbitration register handling Marc Kleine-Budde
[not found] ` <1378711513-2548-6-git-send-email-b.spranger@linutronix.de>
2013-09-09 9:37 ` [PATCH 05/16] c_can: use 32 bit access for D_CAN Marc Kleine-Budde
[not found] ` <1378711513-2548-7-git-send-email-b.spranger@linutronix.de>
2013-09-09 9:39 ` [PATCH 06/16] c_can: consider set bittiming may fail Marc Kleine-Budde
[not found] ` <1378711513-2548-9-git-send-email-b.spranger@linutronix.de>
2013-09-09 9:47 ` [PATCH 08/16] c_can: Add FlexCard CAN TX fifo support Marc Kleine-Budde
[not found] ` <1378711513-2548-11-git-send-email-b.spranger@linutronix.de>
2013-09-09 9:57 ` [PATCH 10/16] c_can: add 16bit align 32bit access functions Marc Kleine-Budde
[not found] ` <1378711513-2548-12-git-send-email-b.spranger@linutronix.de>
2013-09-09 10:05 ` [PATCH 11/16] c_can: stop netqueue if hardware is busy Marc Kleine-Budde
2013-09-09 10:21 ` Marc Kleine-Budde
[not found] ` <1378711513-2548-13-git-send-email-b.spranger@linutronix.de>
2013-09-09 10:21 ` [PATCH 12/16] c_can: Add flag to disable automatic retransmission of CAN frames Marc Kleine-Budde
2013-09-09 10:34 ` Marc Kleine-Budde [this message]
[not found] ` <1378711513-2548-14-git-send-email-b.spranger@linutronix.de>
2013-09-09 10:24 ` [PATCH 13/16] c_can: flexcard: add ioctl to reset FIFO message object Marc Kleine-Budde
[not found] ` <1378711513-2548-16-git-send-email-b.spranger@linutronix.de>
2013-09-09 10:29 ` [PATCH 15/16] flexcard: can: Configure CAN loopback packages (TXACK) Marc Kleine-Budde
[not found] ` <1378711513-2548-17-git-send-email-b.spranger@linutronix.de>
2013-09-09 10:31 ` [PATCH 16/16] c_can: fix TX packet accounting Marc Kleine-Budde
[not found] ` <1378711513-2548-5-git-send-email-b.spranger@linutronix.de>
2013-09-09 10:51 ` [PATCH 04/16] c_can: fix receive buffer configuration Marc Kleine-Budde
[not found] ` <1378711513-2548-10-git-send-email-b.spranger@linutronix.de>
2013-09-09 11:20 ` [PATCH 09/16] c_can: expicit 32bit access on D_CAN to message buffer data register Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522DA427.2090008@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Alexander.Frank@eberspaecher.com \
--cc=b.spranger@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=dengler@linutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).