linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Ico <can@zevv.nl>
Cc: linux-can <linux-can@vger.kernel.org>
Subject: Re: CAN libpcap capture endianess
Date: Wed, 11 Sep 2013 20:22:01 +0200	[thread overview]
Message-ID: <5230B4C9.4070904@pengutronix.de> (raw)
In-Reply-To: <1378920814-sup-4559@pruts.nl>

[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]

Hello,

On 09/11/2013 07:42 PM, Ico wrote:
> Recently I tried the CANopen module in wireshark to sniff on my slcan
> interface, but the dissector seemed to mix up the endianess of the

When opening your attached files I don't see any CANopen related
dissecting happening in my wireshark (Version 1.10.1 (SVN Rev 50926 from
/trunk-1.10), from current Debian testing/jessie). Just normal raw CAN
frames are displayed.

> capture. The source of the dissector seems to assume the CANopen data is
> encoded in big endian, altough afaik CANopen uses little endian for its
> data.

Maybe you are mixing CANopen and plain raw CAN frames.

> I contacted Yegor Yefremov, the contributor of the CANopen dissector,
> who is now just confused as I am: he made some captures on his own
> setup, on which the endianess is indeed different then from mine.
> 
> We both run on x86, so host endianess does not seem to be part of the
> problem.

But you're using a 64 bit system while Yegor uses a 32 bit one
(according to your notes below).

> Hereby I attach two capture files, one made on my setup, and one made by
> Yegor. Can oneone check which one has the proper endianess, and maybe
> take a look at the current CANopen dissector in wireshark to see if the
> implementation is ok?

Your dump doesn't look correct in my wireshark, it has alternating
extended and standard frames and the standard frames have identifiers of
0x060000 which is not valid.

Does the command line tool candump show proper frames?

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

  reply	other threads:[~2013-09-11 18:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 17:42 CAN libpcap capture endianess Ico
2013-09-11 18:22 ` Marc Kleine-Budde [this message]
2013-09-11 18:30   ` Ico Doornekamp
2013-09-11 18:38     ` Marc Kleine-Budde
2013-09-11 18:53       ` Ico Doornekamp
2013-09-11 19:22         ` Oliver Hartkopp
2013-09-11 19:17       ` Oliver Hartkopp
2013-09-11 19:34         ` Marc Kleine-Budde
2013-09-11 19:37 ` Marc Kleine-Budde
2013-09-11 20:05   ` Ico Doornekamp
2013-09-11 20:11     ` Marc Kleine-Budde
2013-09-12  6:52       ` Ico Doornekamp
2013-09-12  8:00         ` Marc Kleine-Budde
2013-09-12  8:47           ` Ico Doornekamp
2013-09-12  8:52             ` Marc Kleine-Budde
2013-09-12  9:09               ` Ico Doornekamp
2013-09-12  9:13                 ` Marc Kleine-Budde
2013-09-12  9:31                   ` Ico Doornekamp
2016-05-10 19:25 ` Ico Doornekamp
2016-05-11  7:40   ` Oliver Hartkopp
     [not found]     ` <1462952665-sup-1016@pruts.nl>
2016-05-11  8:17       ` Oliver Hartkopp
2016-05-11 12:28         ` Ico Doornekamp
2016-05-11 13:25           ` Oliver Hartkopp
2016-05-11 17:01             ` Ico Doornekamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5230B4C9.4070904@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=can@zevv.nl \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).