Re: [PATCH v3] slcand: add slcan_attach and UART settings

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 13.09.2013 13:29, Stefan Wahren wrote:
> Hello Yegor,
> 
> Am 13.09.2013 12:11, schrieb yegorslists@googlemail.com:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> slcand takes settings known from slcan_attach to configure CAN
>> interface, like open/close channel, set bitrate etc (Oliver Hartkopp).
>>
>> In addition -S option sets UART's baudrate (Yegor Yefremov).
>>
>> This way slcand combines three autilities in one: old slcand,
>> slcan_attach and stty.
>>
>> Example: slcand -o -s8 -S 3000000 ttyUSB0
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> CC: stefan.wahren@i2se.com
>> CC: socketcan@hartkopp.net
>> CC: mkl@pengutronix.de
>> ---
>> Changes since v2:
>>    More style fixes as suggested by Stefan Wahren
>> Changes since v1:
>>    Implement suggestions from Stefan Wahren
>>    - fix style issues
>>    - changed look_up_uart_speed parameter from int to long int
>>    - look_up_uart_speed return value will be checked for unsupported baudrates
>>   slcand.c |  297
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++---------
>>   1 files changed, 255 insertions(+), 42 deletions(-)
>>


> okay, looks good to me.
> 
> Best regards
> 
> Stefan
> 

Hi all,

i applied the v3 patch to the can-utils git repo.

Thanks!

I tried linux/scripts/checkpatch.pl which provided tons of issues :-(

Therefore i fixed up the entire coding style and removed an empty statement
in the 'if (speed)' condition to make sure, that the write() statement is not
unintentionally optimized away by the compiler %-)

See changes here:

https://gitorious.org/linux-can/can-utils/commit/35d2bc1381f04e0fcc5baadf9d1ddad8db0187d3 

There's still one warning left:

slcand.c: In function 'daemonize':
slcand.c:180:8: warning: variable 'dummyFile' set but not used [-Wunused-but-set-variable]
  FILE *dummyFile;
        ^

Any suggestion?

Best regards,
Oliver