From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Brian Thorne <hardbyte@gmail.com>, linux-can@vger.kernel.org
Subject: Re: [PATCH can-next] Add broadcast manager documentation
Date: Tue, 15 Oct 2013 09:20:18 +0200 [thread overview]
Message-ID: <525CECB2.4040605@pengutronix.de> (raw)
In-Reply-To: <525CCB3C.8050609@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On 10/15/2013 06:57 AM, Oliver Hartkopp wrote:
> On 14.10.2013 22:02, Marc Kleine-Budde wrote:
>> On 10/14/2013 09:41 PM, Oliver Hartkopp wrote:
>
>>> + configuration message is defined. The basic BCM configuration message used
>>> + to communicate with the broadcast manager and the available operations are
>>> + defined in the linux/can/bcm.h include. The BCM message consists of a
>>
>> Nitpick
>> It's "include/uapi/linux/can/bcm.h" in recent kernel trees.
>>
>
> AFAIK the uapi directory is the place where the 'user API' relevant header
> files are /generated/ at build time. Finally these header files are copied to
>
> /usr/include/linux/...
>
> in the different Linux distributions to be accessed by application developers.
>
> So in the application C code it's still:
>
> #include <linux/can.h>
> #include <linux/can/raw.h>
> #include <linux/can/bcm.h>
>
> Right?
Correct, from that point of view (which makes more sense).
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2013-10-15 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 0:56 [PATCH] Broadcast manager documentation Brian Thorne
2013-10-08 8:24 ` Oliver Hartkopp
2013-10-08 14:03 ` Marc Kleine-Budde
2013-10-14 19:41 ` [PATCH can-next] Add broadcast " Oliver Hartkopp
2013-10-14 20:02 ` Marc Kleine-Budde
[not found] ` <CAENe87q9PCCJjgzDp-D7GfhJkGeBJU6kog+YuMHKkNbacg1bTA@mail.gmail.com>
2013-10-14 21:00 ` Brian Thorne
2013-10-15 4:57 ` Oliver Hartkopp
2013-10-15 7:20 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525CECB2.4040605@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=hardbyte@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).