linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Max S." <max@schneidersoft.net>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	linux-can <linux-can@vger.kernel.org>
Subject: Re: GS_USB
Date: Mon, 11 Nov 2013 16:41:38 +0100	[thread overview]
Message-ID: <5280FAB2.3030600@hartkopp.net> (raw)
In-Reply-To: <3370f1eba56bbe04176f4d14808c1dc0@grandegger.com>


>> Manual recovery is not supported. The node can leave bus off state if
> 
>> it detects 128 occurrences of 11 consecutive recessive bits on the bus.
> 
>> Maybe I can trick the controller out of bus off by doing a software
> 
>> reset. That's probably not going to be a clean solution though.
> 
> 
> 
> Would be nice if manual recovery is supported but it's not a requirement.
> 
> Maybe you could make the delay before restarting bus-off configurable
> 
> using the "restart-ms" argument.
> 
> 
> 
> For further information have a look to:
> 
> 
> 
> http://lxr.free-electrons.com/source/Documentation/networking/can.txt#L891
> 
> 

Yes.

Usually the CAN controller sits in BUS_OFF until it detects correct CAN frames
_or_ until the controller is re-initialized.

The CAN controller should not recover itself as this might be wrong depending
on the use-case.

Therefore the manual "restart" can be initiated by some user application or it
can be handled inside the driver e.g. 200ms after a BUS_OFF detection by the
"restart-ms" option.

Regards,
Oliver


  reply	other threads:[~2013-11-11 15:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 12:31 GS_USB Max S.
2013-10-04 13:23 ` GS_USB Marc Kleine-Budde
2013-10-05 20:36 ` GS_USB Wolfgang Grandegger
2013-10-07 14:22   ` GS_USB Max S.
2013-10-07 14:37     ` GS_USB Wolfgang Grandegger
2013-10-07 19:52       ` GS_USB Max S.
2013-10-07 20:30         ` GS_USB Wolfgang Grandegger
2013-11-03 17:12           ` GS_USB Max S.
2013-11-03 19:42             ` GS_USB Wolfgang Grandegger
2013-11-09 23:19             ` GS_USB Wolfgang Grandegger
2013-11-11  2:10               ` GS_USB Max S.
2013-11-11  8:05                 ` GS_USB Wolfgang Grandegger
2013-11-11 15:41                   ` Oliver Hartkopp [this message]
     [not found]                     ` <1384199350.3483.20.camel@blackbox>
2013-11-11 21:49                       ` GS_USB Oliver Hartkopp
2013-11-15 10:39                         ` GS_USB Max S.
2013-11-23 16:05                           ` GS_USB Max S.
2013-12-04 21:17                             ` GS_USB Max S.
2013-12-05 19:05                               ` GS_USB Oliver Hartkopp
2013-12-05 19:07                                 ` GS_USB Oliver Hartkopp
2013-12-09 17:53                                   ` GS_USB Max S.
2013-12-05 20:18                               ` GS_USB Wolfgang Grandegger
2013-12-05 20:42                                 ` GS_USB Wolfgang Grandegger
2013-12-07 10:06                             ` GS_USB Wolfgang Grandegger
2013-12-09 10:52                               ` GS_USB Marc Kleine-Budde
2013-12-09 13:15                                 ` GS_USB Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5280FAB2.3030600@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=max@schneidersoft.net \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).