Re: [PATCH v3] can: fix sja1000 pre_irq/post_irq handling

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 18.11.2013 22:15, Kurt Van Dijck wrote:
> Oliver,
> 
> On Mon, Nov 18, 2013 at 02:01:14PM +0100, Oliver Hartkopp wrote:
>> The SJA1000 driver provides optional function pointers to handle specific
>> hardware setups at interrupt time.
>>
>> This patch fixes the issue that the sja1000_interrupt() function may have
>> returned IRQ_NONE without processing the post_irq function. Additionally
>> an introduced and documented return value from the pre_irq function is
>> checked to skip the entire interrupt handling on pre_irq function errors.
> 
> You combine fixes and new features in 1 patch.

You are right. The return value is not really a fix.

> Both are tried in addressing the problem with peak_pci,
> but that doesn't make them depend on each other.

It mainly isn't related to peak_pci. It just emerged in the code review when
investigating an issue with the peak_pci driver.

I have no strong opinion about splitting up the patch.

Regards,
Oliver