From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Glen, Andrew" <AGlen@bepmarine.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v2] can: c_can: don't call pm_runtime_get_sync() from IRQ handler
Date: Mon, 25 Nov 2013 21:42:48 +0100 [thread overview]
Message-ID: <5293B648.4040108@pengutronix.de> (raw)
In-Reply-To: <2A43324E02E34840B044C9DC92214480090568F0@AMDTCEX12.actuant.pri>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On 11/25/2013 09:34 PM, Glen, Andrew wrote:
> From: <mkl@pengutronix.de>
>
> The c_can driver contains a callpath (c_can_poll -> c_can_state_change ->
> c_can_get_berr_counter) which may call pm_runtime_get_sync() from the IRQ handler, which is not allowed.
>
> This problem is fixed by introducing __c_can_get_berr_counter, which will not call pm_runtime_get_sync().
>
> Reported-by: Andrew Glen <AGlen@bepmarine.com>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Andrew Glen <AGlen@bepmarine.com>
> Tested-by: Andrew Glen <AGlen@bepmarine.com>
Thanks for fixing and testing.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2013-11-25 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 20:34 [PATCH v2] can: c_can: don't call pm_runtime_get_sync() from IRQ handler Glen, Andrew
2013-11-25 20:42 ` Marc Kleine-Budde [this message]
2013-11-26 2:15 ` Glen, Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293B648.4040108@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=AGlen@bepmarine.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).