arbitration lost error reporting (was: Re: [PATCH v6] can: sja1000: fix {pre,post}_irq() handling and IRQ handler return value)

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1542 bytes --]

On 12/06/2013 11:57 AM, Richard Andrysek wrote:
>> You can send a diff, to illustrate your changes.
> 
> $ diff /cygdrive/X/bug1/sja1000.c /cygdrive/X/modified_sja1000.c

"diff -u" is preferred, but no need to resend it.

>>> But I prefare to make some kind of "ioctl" support for that. There are
>>> applications, where it shall not happend. Concurrently I've played with
>>> taskset and priorities.
>>
>> ioctl() is not a option here, but there are two options:
>> 1) We can put the arbitration lost error to the bus errors,
>>    but I think that's wrong.
>> 2) You can add another ctrlmode to disable arbitration lost error
>>    reporting.

> As Wolgang mentioned it has nothing to do with the patch v6.
> Enabling/diabling IRQs is a new feature. So I don't know, if here it is a
> right place to continue about that.

Yes, why not? :)
As I outlined above you have two options. I prefer option 2 and it has a
big change of going mainline. The implementation is similar to
CAN_CTRLMODE_BERR_REPORTING, just look for it in the kernel source tree
and add a new define for arbitration lost error reporting.

Do you have a preferred name for the define?
- CAN_CTRLMODE_AERR_REPORTING
- CAN_CTRLMODE_ARBITRATIONERR_REPORTING to

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]