From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: sja1000 interrupt problem Date: Fri, 13 Dec 2013 17:25:51 +0100 Message-ID: <52AB350F.7030108@hartkopp.net> References: <85256584a266750b1330cfae8bebd55c@grandegger.com> <5288D236.403@hartkopp.net> <5288FB91.9050703@grandegger.com> <52892B21.9000501@grandegger.com> <333c0fd4238558062478212eb0704b04@grandegger.com> <52A71B6C.3050600@hartkopp.net> <8e5f03acb59e16a0ebcd31499a533f15@grandegger.com> <52A73BB1.7070701@hartkopp.net> <52A783B2.5020002@grandegger.com> <52A89A0A.7010803@hartkopp.net> <52A8BC94.6010805@grandegger.com> <52A953F3.3000605@hartkopp.net> <52A9F491.3060406@ha rtkopp.net> <52AA3F16.3070309@grandegger.com> <52AAD5A9.5030607@hartkopp.net> <56963612d7fd8d32efa0dc44dfc4593a@grandegger.com> <55f73f8bda4d14c10394f50a69178b7f@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mo-p00-ob.rzone.de ([81.169.146.161]:58291 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538Ab3LMQZx (ORCPT ); Fri, 13 Dec 2013 11:25:53 -0500 In-Reply-To: <55f73f8bda4d14c10394f50a69178b7f@grandegger.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Wolfgang Grandegger Cc: Austin Schuh , Pavel Pisa , linux-can@vger.kernel.org On 13.12.2013 11:09, Wolfgang Grandegger wrote: > I mean modifying: > > > > if (!noirqdebug) { > > raw_spin_lock(&desc->lock); > > note_interrupt(action->irq, desc, action_ret); > > raw_spin_unlock(&desc->lock); > > } > > > > here http://lxr.free-electrons.com/source/kernel/irq/manage.c#L865. > > > > Maybe a normal spin_lock is already OK. > No change in behaviour when adding this patch. But I did not use IRQ debugging in my machine ;-) Regards, Oliver