linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
	Wolfgang Grandegger <wg@grandegger.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH v2 2/2] can: mcp251x: Add device tree support
Date: Mon, 16 Dec 2013 11:20:04 +0100	[thread overview]
Message-ID: <52AED3D4.40608@pengutronix.de> (raw)
In-Reply-To: <1387116961-15261-2-git-send-email-shc_work@mail.ru>

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

cOn 12/15/2013 03:16 PM, Alexander Shiyan wrote:
> This patch adds Device Tree support to the Microchip MCP251X driver.

What about completing the clock support for the driver, too? You get the
clock, but it's never enabled. It probably works on your board because
it's a fixed always on clock.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

  reply	other threads:[~2013-12-16 10:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-15 14:16 [PATCH v2 1/2] can: mcp251x: Convert to devm-* API Alexander Shiyan
2013-12-15 14:16 ` [PATCH v2 2/2] can: mcp251x: Add device tree support Alexander Shiyan
2013-12-16 10:20   ` Marc Kleine-Budde [this message]
2013-12-16 10:53     ` Alexander Shiyan
2013-12-16 10:17 ` [PATCH v2 1/2] can: mcp251x: Convert to devm-* API Marc Kleine-Budde
2013-12-17 11:08   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AED3D4.40608@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-can@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shc_work@mail.ru \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).