* Re: [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast [not found] <52b60e29.e6MbNbPY4sH1N+Ql%fengguang.wu@intel.com> @ 2013-12-21 21:58 ` Marc Kleine-Budde 2013-12-21 22:57 ` Ezequiel Garcia 0 siblings, 1 reply; 5+ messages in thread From: Marc Kleine-Budde @ 2013-12-21 21:58 UTC (permalink / raw) To: linux-can@vger.kernel.org; +Cc: Ezequiel Garcia, Sergei Shtylyov [-- Attachment #1: Type: text/plain, Size: 1340 bytes --] On 12/21/2013 10:54 PM, kbuild test robot wrote: > tree: git://gitorious.org/linux-can/linux-can-next for-davem > head: 5dd64fac3ff28aab5e92548a066c175e00cc9da4 > commit: 5dd64fac3ff28aab5e92548a066c175e00cc9da4 [3/3] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices > config: make ARCH=um allyesconfig > > All warnings: > > drivers/net/can/ti_hecc.c: In function 'ti_hecc_probe': > drivers/net/can/ti_hecc.c:909:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] > addr = ioremap(mem->start, resource_size(mem)); > ^ >>> drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast [enabled by default] > addr = ioremap(mem->start, resource_size(mem)); > ^ > drivers/net/can/ti_hecc.c:974:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] > iounmap(addr); > ^ > cc1: some warnings being treated as errors Should we go back to "depends on ARM"? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 259 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast 2013-12-21 21:58 ` [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast Marc Kleine-Budde @ 2013-12-21 22:57 ` Ezequiel Garcia 2013-12-21 23:04 ` Marc Kleine-Budde 0 siblings, 1 reply; 5+ messages in thread From: Ezequiel Garcia @ 2013-12-21 22:57 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: linux-can@vger.kernel.org, Sergei Shtylyov On Sat, Dec 21, 2013 at 10:58:57PM +0100, Marc Kleine-Budde wrote: > On 12/21/2013 10:54 PM, kbuild test robot wrote: > > tree: git://gitorious.org/linux-can/linux-can-next for-davem > > head: 5dd64fac3ff28aab5e92548a066c175e00cc9da4 > > commit: 5dd64fac3ff28aab5e92548a066c175e00cc9da4 [3/3] can: ti_hecc: Use the OMAP2PLUS dependency for omap2plus devices > > config: make ARCH=um allyesconfig > > > > All warnings: > > > > drivers/net/can/ti_hecc.c: In function 'ti_hecc_probe': > > drivers/net/can/ti_hecc.c:909:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration] > > addr = ioremap(mem->start, resource_size(mem)); > > ^ > >>> drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast [enabled by default] > > addr = ioremap(mem->start, resource_size(mem)); > > ^ > > drivers/net/can/ti_hecc.c:974:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration] > > iounmap(addr); > > ^ > > cc1: some warnings being treated as errors > > Should we go back to "depends on ARM"? > Well, it seems user-mode linux has no ioremap? So, maybe we'll have to live with "depends on ARM" unless anyone has a better idea. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast 2013-12-21 22:57 ` Ezequiel Garcia @ 2013-12-21 23:04 ` Marc Kleine-Budde 2013-12-21 23:21 ` Ezequiel Garcia 0 siblings, 1 reply; 5+ messages in thread From: Marc Kleine-Budde @ 2013-12-21 23:04 UTC (permalink / raw) To: Ezequiel Garcia; +Cc: linux-can@vger.kernel.org, Sergei Shtylyov [-- Attachment #1: Type: text/plain, Size: 545 bytes --] On 12/21/2013 11:57 PM, Ezequiel Garcia wrote: [...] >> Should we go back to "depends on ARM"? > Well, it seems user-mode linux has no ioremap? So, maybe we'll have to > live with "depends on ARM" unless anyone has a better idea. Then it's Patch v2. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 259 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast 2013-12-21 23:04 ` Marc Kleine-Budde @ 2013-12-21 23:21 ` Ezequiel Garcia 2013-12-22 13:35 ` Sergei Shtylyov 0 siblings, 1 reply; 5+ messages in thread From: Ezequiel Garcia @ 2013-12-21 23:21 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: linux-can@vger.kernel.org, Sergei Shtylyov On Sun, Dec 22, 2013 at 12:04:53AM +0100, Marc Kleine-Budde wrote: > On 12/21/2013 11:57 PM, Ezequiel Garcia wrote: > [...] > > >> Should we go back to "depends on ARM"? > > > Well, it seems user-mode linux has no ioremap? So, maybe we'll have to > > live with "depends on ARM" unless anyone has a better idea. > > Then it's Patch v2. > What puzzles me is that other drivers are doing this same COMPILE_TEST trick (see MTD_NAND_SH_FLCTL). I guess they just ignore the 0-day build error? Anyway... I agree with going with v2. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast 2013-12-21 23:21 ` Ezequiel Garcia @ 2013-12-22 13:35 ` Sergei Shtylyov 0 siblings, 0 replies; 5+ messages in thread From: Sergei Shtylyov @ 2013-12-22 13:35 UTC (permalink / raw) To: Ezequiel Garcia, Marc Kleine-Budde; +Cc: linux-can@vger.kernel.org Hello. On 22-12-2013 3:21, Ezequiel Garcia wrote: >>>> Should we go back to "depends on ARM"? >>> Well, it seems user-mode linux has no ioremap? So, maybe we'll have to >>> live with "depends on ARM" unless anyone has a better idea. >> Then it's Patch v2. > What puzzles me is that other drivers are doing this same COMPILE_TEST > trick (see MTD_NAND_SH_FLCTL). I guess they just ignore the 0-day build > error? Perhaps they just don't use ioremap() directly but use its devm_*() variants? WBR, Sergei ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-22 13:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <52b60e29.e6MbNbPY4sH1N+Ql%fengguang.wu@intel.com>
2013-12-21 21:58 ` [can:for-davem 3/3] drivers/net/can/ti_hecc.c:909:7: warning: assignment makes pointer from integer without a cast Marc Kleine-Budde
2013-12-21 22:57 ` Ezequiel Garcia
2013-12-21 23:04 ` Marc Kleine-Budde
2013-12-21 23:21 ` Ezequiel Garcia
2013-12-22 13:35 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).