From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Yegor Yefremov <yegorslists@googlemail.com>
Subject: Re: [PATCH can-utils v2 1/3] headers: use include/linux only for Linux kernel headers
Date: Mon, 13 Jan 2014 07:23:55 +0100 [thread overview]
Message-ID: <52D3867B.6090108@hartkopp.net> (raw)
In-Reply-To: <1389561879-16729-2-git-send-email-u.kleine-koenig@pengutronix.de>
Hello Uwe,
On 12.01.2014 22:24, Uwe Kleine-König wrote:
> - use __kernel_sa_family_t instead of sa_family_t which requires
> <linux/socket.h from Linux 3.1 or later. Unfortunately this makes
> can-utils FTBFS on e.g. Debian squeeze. If this is an issue this
> could be fixed by adding something like:
This was exactly the idea to have a separate set of include files to make sure
the 'newest and greatest' tools can be build even on 2.6.24 environments where
there was no SocketCAN in mainline Linux.
And e.g. this
> #include <linux/can.h>
> -#include <linux/can/isotp.h>
> +#include "isotp.h"
> #include <linux/if_tun.h>
should be avoided too.
Please only fix the copyright information in this patch.
The wrong 3.1 -> 3.2 comparison should be fixed in a separate patch too.
But reorder the includes in a way you suggest needs at least some more
discussion (see requirements above).
Regards,
Oliver
next prev parent reply other threads:[~2014-01-13 6:23 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 19:05 license issues of can-utils Uwe Kleine-König
2013-08-17 20:24 ` Marc Kleine-Budde
2013-08-18 10:26 ` Oliver Hartkopp
2014-01-11 23:10 ` [PATCH can-utils 0/3] License cleanup Uwe Kleine-König
2014-01-11 23:10 ` [PATCH can-utils 1/3] Update license information for some header files Uwe Kleine-König
2014-01-12 10:09 ` Oliver Hartkopp
2014-01-12 19:02 ` [PATCH] can: add explicit copyrights to can userspace header Uwe Kleine-König
2014-01-12 19:27 ` Oliver Hartkopp
2014-01-16 16:27 ` Marc Kleine-Budde
2014-01-12 19:53 ` [PATCH can-utils 1/3] Update license information for some header files Uwe Kleine-König
2014-01-11 23:10 ` [PATCH can-utils 2/3] ioctl.h: drop unused header Uwe Kleine-König
2014-01-12 10:18 ` Oliver Hartkopp
2014-01-11 23:10 ` [PATCH can-utils 3/3] slcand: remove program as it is undistributable Uwe Kleine-König
2014-01-11 23:38 ` Yegor Yefremov
2014-01-12 10:57 ` Oliver Hartkopp
2014-01-12 16:09 ` Yegor Yefremov
2014-01-12 18:22 ` Oliver Hartkopp
2014-01-12 19:54 ` Yegor Yefremov
2014-01-12 19:59 ` Oliver Hartkopp
2014-01-12 21:24 ` [PATCH can-utils v2 0/3] License cleanup Uwe Kleine-König
2014-01-12 21:24 ` [PATCH can-utils v2 1/3] headers: use include/linux only for Linux kernel headers Uwe Kleine-König
2014-01-13 6:23 ` Oliver Hartkopp [this message]
2014-01-13 7:20 ` Uwe Kleine-König
2014-01-13 18:25 ` Oliver Hartkopp
2014-01-13 20:45 ` Uwe Kleine-König
2014-01-13 21:18 ` Oliver Hartkopp
2014-01-13 21:26 ` Uwe Kleine-König
2014-01-13 21:31 ` Oliver Hartkopp
2014-01-13 21:37 ` Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 0/4] License cleanup Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 1/4] Remove two unused header files Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 2/4] Move includes copied from the Linux kernel into include/linux Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 3/4] ioctl.h: drop unused header Uwe Kleine-König
2014-01-13 21:57 ` [PATCH can-utils v4 4/4] isotp.h: add explicit license information Uwe Kleine-König
2014-01-14 7:01 ` Oliver Hartkopp
2014-01-14 8:46 ` Uwe Kleine-König
2014-01-14 15:49 ` Oliver Hartkopp
2014-01-16 19:18 ` Uwe Kleine-König
2014-01-16 22:05 ` Marc Kleine-Budde
2014-01-12 21:24 ` [PATCH can-utils v2 2/3] ioctl.h: drop unused header Uwe Kleine-König
2014-01-12 21:24 ` [PATCH can-utils v2 3/3] isotp.h: add explicit license information Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D3867B.6090108@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).