[PATCH] slcanpty: declare command buffer static

[PATCH] slcanpty: declare command buffer static

[yegorslists]

From: Yegor Yefremov <yegorslists@googlemail.com>

ASCII command buffer char buf[200] must be declared as static,
because it holds incomplete commands between pty2can() calls.
Without static it is not guaranteed, that buf retains the same
data between calls.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 slcanpty.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/slcanpty.c b/slcanpty.c
index 2c1cabe..c062a02 100644
--- a/slcanpty.c
+++ b/slcanpty.c
@@ -68,7 +68,7 @@ int pty2can(int pty, int socket, struct can_filter *fi,
 {
 	int nbytes;
 	char cmd;
-	char buf[200];
+	static char buf[200];
 	char replybuf[10]; /* for answers to received commands */
 	int ptr;
 	struct can_frame frame;
-- 
1.7.7

Re: [PATCH] slcanpty: declare command buffer static

[Oliver Hartkopp]

On 13.01.2014 14:29, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> ASCII command buffer char buf[200] must be declared as static,
> because it holds incomplete commands between pty2can() calls.
> Without static it is not guaranteed, that buf retains the same
> data between calls.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Hi Yegor,

indeed the rxoffset is a static variable to handle incomplete ASCII commands
(in buf[]) and therefore it makes no sense when the referenced buffer would
not be static then ...

Thanks for catching this.

Best regards,
Oliver

> ---
>  slcanpty.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/slcanpty.c b/slcanpty.c
> index 2c1cabe..c062a02 100644
> --- a/slcanpty.c
> +++ b/slcanpty.c
> @@ -68,7 +68,7 @@ int pty2can(int pty, int socket, struct can_filter *fi,
>  {
>  	int nbytes;
>  	char cmd;
> -	char buf[200];
> +	static char buf[200];
>  	char replybuf[10]; /* for answers to received commands */
>  	int ptr;
>  	struct can_frame frame;
> 

Re: [PATCH] slcanpty: declare command buffer static

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On 01/13/2014 02:29 PM, yegorslists@googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> ASCII command buffer char buf[200] must be declared as static,
> because it holds incomplete commands between pty2can() calls.
> Without static it is not guaranteed, that buf retains the same
> data between calls.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Applied to master.

Tnx,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]