linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Yegor Yefremov" <yegorslists@googlemail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH 2/2] slcand: reimplement daemonize routine
Date: Mon, 13 Jan 2014 19:00:16 +0100	[thread overview]
Message-ID: <52D429B0.3080602@hartkopp.net> (raw)
In-Reply-To: <CAGm1_kuDApxXrm+3+CETQ7+KhA5f9cnGVjAMe_0PVU92UaZ0sQ@mail.gmail.com>



On 13.01.2014 11:02, Yegor Yefremov wrote:
> On Mon, Jan 13, 2014 at 10:58 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>> Hello Yegor,
>>
>> On Mon, Jan 13, 2014 at 09:54:05AM +0100, yegorslists@googlemail.com wrote:
>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> Replace daemonize() routine with daemone() system call, because of
>>> conflicting licenses. daemonize() routine was derived from under
>>> GNU Free Documentation License licensed code. This license is
>>> incompatible with GPL-2+.
>>>
>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> Thanks.
>>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Just a note. I've tested the patches with our VScom USB-CAN device at
> 3Mbit/s. So
> far everything was working as expected: daemon started and I could
> send/receive frames.
> 

Great!
That was really a cool cleanup: 6 insertions(+), 138 deletions(-)
And when it works it's even better :-)

Thanks!

Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>


  reply	other threads:[~2014-01-13 18:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13  8:54 [PATCH 1/2] slcand: add flow control option yegorslists
2014-01-13  8:54 ` [PATCH 2/2] slcand: reimplement daemonize routine yegorslists
2014-01-13  9:58   ` Uwe Kleine-König
2014-01-13 10:02     ` Yegor Yefremov
2014-01-13 18:00       ` Oliver Hartkopp [this message]
2014-01-16 16:19   ` Marc Kleine-Budde
2014-01-13 18:01 ` [PATCH 1/2] slcand: add flow control option Oliver Hartkopp
2014-01-16 16:19 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D429B0.3080602@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yegorslists@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).