From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Stephane Grosjean <s.grosjean@peak-system.com>
Subject: Re: [PATCH RFC] can fd: Add separate bittiming infrastructure
Date: Thu, 16 Jan 2014 17:30:10 +0100 [thread overview]
Message-ID: <52D80912.1090700@pengutronix.de> (raw)
In-Reply-To: <52D6CB48.9010206@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 921 bytes --]
On 01/15/2014 06:54 PM, Oliver Hartkopp wrote:
> Introduce a second set of bitrate configuration for the (potential different)
> data bitrate. The CAN FD arbitration bitrate is stored in the existing
> bittiming configuration space.
>
> TODO:
> The functions can_calc_bittiming(), can_fixup_bittiming() should change their
> parameters from
>
> (struct net_device *dev, struct can_bittiming *bt)
> to
> (struct can_bittiming *bt, const struct can_bittiming_const *btc, const struct can_clock *clk)
Are there any netdev_printk()? I don't want to loose the explicit device
information.
Otherwise looks good so far.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-01-16 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 17:54 [PATCH RFC] can fd: Add separate bittiming infrastructure Oliver Hartkopp
2014-01-16 16:30 ` Marc Kleine-Budde [this message]
2014-01-17 7:44 ` Stephane Grosjean
2014-01-18 17:34 ` Oliver Hartkopp
2014-01-21 8:42 ` Stephane Grosjean
2014-01-21 9:56 ` Oliver Hartkopp
2014-01-21 10:22 ` [RFC] can fd: backward compatibility for CANFD8 Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D80912.1090700@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).