linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v5 5/5] include: Move includes copied from the Linux kernel into include/linux
Date: Thu, 16 Jan 2014 23:11:28 +0100	[thread overview]
Message-ID: <52D85910.8000200@pengutronix.de> (raw)
In-Reply-To: <20140116192818.GC25911@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On 01/16/2014 08:28 PM, Uwe Kleine-König wrote:
> On Thu, Jan 16, 2014 at 05:12:34PM +0100, Marc Kleine-Budde wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> This makes it possible to update the copies more easily, e.g.:
>>
>> 	cd $path_to_linux_repo
>> 	make headers_install
>> 	rsync -a --delete --exclude .\* usr/include/linux/can* $path_to_can_utils/include/linux
>>
>> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

> I want to have pointed out in the commit log that it was you who added
> isotp.h to the move. I don't care that much for your split into two
> patches to fix the #includes first, but IMHO that should be documented,
> too.

Yes, but no. I imported the isotp header, but not from the kernel. It
was imported from the berlios svn repo.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

  reply	other threads:[~2014-01-16 22:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 16:12 [PATCH v5 1/5] License cleanup Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 1/5] include: Remove two unused header files Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 2/5] ioctl.h: drop unused header Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 3/5] isotp.h: add explicit license information Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 4/5] include/socketcan: prepare headers to be moved to include/linux Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 5/5] include: Move includes copied from the Linux kernel into include/linux Marc Kleine-Budde
2014-01-16 19:28   ` Uwe Kleine-König
2014-01-16 22:11     ` Marc Kleine-Budde [this message]
2014-01-17 13:37       ` Uwe Kleine-König
2014-01-17 14:04         ` Marc Kleine-Budde
2014-01-17 20:36           ` Uwe Kleine-König
2014-01-18 12:18             ` Oliver Hartkopp
2014-01-21  9:53               ` Uwe Kleine-König
2014-01-21  9:59                 ` Yegor Yefremov
2014-01-21 10:32                   ` Uwe Kleine-König
2014-01-21 11:34                 ` Oliver Hartkopp
2014-01-21 11:37                   ` Marc Kleine-Budde
2014-01-21 11:51                     ` Oliver Hartkopp
2014-01-21 12:56                   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D85910.8000200@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).