From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v5 5/5] include: Move includes copied from the Linux kernel into include/linux
Date: Tue, 21 Jan 2014 12:34:23 +0100 [thread overview]
Message-ID: <52DE5B3F.3010900@hartkopp.net> (raw)
In-Reply-To: <20140121095337.GR25911@pengutronix.de>
On 21.01.2014 10:53, Uwe Kleine-König wrote:
> On Sat, Jan 18, 2014 at 01:18:14PM +0100, Oliver Hartkopp wrote:
>> On 17.01.2014 21:36, Uwe Kleine-König wrote:
> I don't see a real reason here, but I read between the lines that you
> prefer isotp to go into the kernel directly instead of into can-utils
> first.
We obviously have different ways to think/discuss :-(
- Yes, isotp is intended for mainline
- isotp.h will not change when it goes into mainline
- therefore can-utils can rely on the existing isotp.h
- therefore isotp.h can stay together with other includes in can-utils
IMO it does not make sense to kick out the isotp tools just because of the
fact that isotp is not in mainline today.
Alternatively we could split the isotp related stuff into another git repo,
e.g. can-isotp-utils and merge them again at the point when isotp is in mainline.
> Anyhow, what I care for is to be able to package can-utils for Debian.
Yes. That would be nice indeed.
> That's what I can do once the updated headers hit can-utils so IMO we
> can stop arguing even if we don't agree 100%.
I hope I was able to focus the discussion some lines before. Don't know if
it's worth the effort to kick out the isotp stuff and merge it later on.
> @Marc or Oliver: Can you please give me a ping as soon as the headers
> hit your public repo. Thanks.
Indeed I would vote for your latest patch set (v5) as the only missing thing
there would be to move isotp.h from include/socketcan/can/isotp.h to
include/linux/can/isotp.h and delete the socketcan directory then.
In Marcs patch set (v6) the license updates got lost at some point.
Best regards,
Oliver
next prev parent reply other threads:[~2014-01-21 11:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 16:12 [PATCH v5 1/5] License cleanup Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 1/5] include: Remove two unused header files Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 2/5] ioctl.h: drop unused header Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 3/5] isotp.h: add explicit license information Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 4/5] include/socketcan: prepare headers to be moved to include/linux Marc Kleine-Budde
2014-01-16 16:12 ` [PATCH v5 5/5] include: Move includes copied from the Linux kernel into include/linux Marc Kleine-Budde
2014-01-16 19:28 ` Uwe Kleine-König
2014-01-16 22:11 ` Marc Kleine-Budde
2014-01-17 13:37 ` Uwe Kleine-König
2014-01-17 14:04 ` Marc Kleine-Budde
2014-01-17 20:36 ` Uwe Kleine-König
2014-01-18 12:18 ` Oliver Hartkopp
2014-01-21 9:53 ` Uwe Kleine-König
2014-01-21 9:59 ` Yegor Yefremov
2014-01-21 10:32 ` Uwe Kleine-König
2014-01-21 11:34 ` Oliver Hartkopp [this message]
2014-01-21 11:37 ` Marc Kleine-Budde
2014-01-21 11:51 ` Oliver Hartkopp
2014-01-21 12:56 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DE5B3F.3010900@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).