From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Michal Sojka <sojkam1@fel.cvut.cz>,
linux-can@vger.kernel.org
Subject: Re: [PATCH] can-utils: Add exact CAN frame length calculation (including bitstuffing)
Date: Mon, 27 Jan 2014 10:26:52 +0100 [thread overview]
Message-ID: <52E6265C.7040601@pengutronix.de> (raw)
In-Reply-To: <52E3D619.4070702@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On 01/25/2014 04:19 PM, Oliver Hartkopp wrote:
[...]
> https://gitorious.org/linux-can/can-utils/source/canbusload.c#L375
>
> E.g. some
>
> enum {
> NO_BITSTUFFING, /* plain bit calculation without bitstuffing */
> BITSTUFFING, /* with bitstuffing following Tindle estimation */
> PRECISE, /* precise calculation including bitstuffing in CRC */
> }
Please add a prefix to those enums.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-01-27 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 13:59 [PATCH] can-utils: Add exact CAN frame length calculation (including bitstuffing) Michal Sojka
2014-01-25 15:19 ` Oliver Hartkopp
2014-01-27 9:26 ` Marc Kleine-Budde [this message]
2014-01-30 10:01 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E6265C.7040601@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).