From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Boris Baskevitch <boris.baskevitch@annecy-elec.fr>,
Daniele Venzano <linux@brownhat.org>,
Josselin Costanzi <josselin.costanzi@mobile-devices.fr>,
Nathan Conrad <nconrad.mlock@gmail.com>,
Dirk Rohleder <dirk@rohleder-bo.de>,
Luis Henriques <luis.henriques@canonical.com>,
kernel-team@lists.ubuntu.com, opensuse-kernel@opensuse.org
Subject: Re: [INFO] BCM and ISOTP crashes Linux 3.11 - 3.13 when running on REAL HW CAN interfaces
Date: Sat, 01 Feb 2014 19:44:27 +0100 [thread overview]
Message-ID: <52ED408B.5010806@pengutronix.de> (raw)
In-Reply-To: <52ED3993.2080404@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 2115 bytes --]
On 02/01/2014 07:14 PM, Oliver Hartkopp wrote:
> Hello all,
>
> at 2013-08-01 Eric Dumazet created this patch to make sure some
> networking rules are enforced in the Linux Kernel in Linux 3.11:
> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=376c7311bdb6efea3322310333576a04d73fbe4c
>
> This affects CAN BCM and CAN ISOTP and leads to a KERNEL CRASH
> when you are *sending* with the BCM or ISOTP on REAL(!) CAN interfaces.
>
> AFAIK there are not so many use cases. That's why it lasted 6 months to detect it :-(
> Virtual CAN and SLCAN interfaces do not have this problem (no echo skbs).
>
> Do I have to care about this issue?
>
> Usually the embedded systems do not have such a recent kernel.
> Regarding desktop distributions Redhat 7 runs a 3.10 kernel which is safe.
>
> But e.g. OpenSuse 13.1 and Ubuntu 13.10 / Linux Mint Petra are based on
> Linux 3.11 and Debian Jessie (current Debian testing) is on Linux 3.12.
>
> The latter have the described problem with BCM / ISOTP until this patch
>
> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=0ae89beb283a0db5980d1d4781c7d7be2f2810d6
>
> is applied by the stable kernel maintainers and distribution maintainers.
> The patch is already upstream for Linux 3.14 but it will take some time
> until it gets into the stable kernels 3.11 - 3.13 and the distributions.
>
> As Linux 3.11 is already end-of-life [EOL] I'll address the Ubuntu and
> OpenSuse maintainers directly so that this patch for 3.11 does not get lost.
> David Miller already queued this patch up for -stable
> Original post: http://marc.info/?l=linux-netdev&m=139107310226665&w=2
At least the Ubuntu maintainers usually pick up the stable patches, so
that they appear "automatically" in Ubuntu's stable. Good Work!
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-02-01 18:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 9:11 [PATCH stable 3.9+] can: add destructor for self generated skbs Oliver Hartkopp
2014-01-30 9:24 ` Marc Kleine-Budde
2014-01-30 23:10 ` Eric Dumazet
2014-01-31 0:27 ` David Miller
[not found] ` <20140130.162723.1124545320708055175.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-02-01 18:14 ` [INFO] BCM and ISOTP crashes Linux 3.11 - 3.13 when running on REAL HW CAN interfaces Oliver Hartkopp
2014-02-01 18:44 ` Marc Kleine-Budde [this message]
2014-02-02 18:00 ` Luis Henriques
2014-02-02 19:29 ` Oliver Hartkopp
2014-02-15 17:42 ` Netdev stable patches status Oliver Hartkopp
2014-02-16 0:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ED408B.5010806@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=boris.baskevitch@annecy-elec.fr \
--cc=dirk@rohleder-bo.de \
--cc=josselin.costanzi@mobile-devices.fr \
--cc=kernel-team@lists.ubuntu.com \
--cc=linux-can@vger.kernel.org \
--cc=linux@brownhat.org \
--cc=luis.henriques@canonical.com \
--cc=nconrad.mlock@gmail.com \
--cc=opensuse-kernel@opensuse.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).