From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: Stephane Grosjean <s.grosjean@peak-system.com>
Subject: Re: [PATCH can-next] Add CAN FD driver infrastructure
Date: Thu, 06 Feb 2014 20:02:11 +0100 [thread overview]
Message-ID: <52F3DC33.6080402@hartkopp.net> (raw)
In-Reply-To: <52F374DC.3000105@pengutronix.de>
On 06.02.2014 12:41, Marc Kleine-Budde wrote:
> On 02/05/2014 08:32 PM, Oliver Hartkopp wrote:
>> This is a combined patch to create the CAN FD driver infrastructure.
>>
>> - add a separate configuration for data bittiming (incl. netlink)
>> - the bitrate information is only provided when the bittiming const exist
>> - add the helper to create canfd frame skbs
>> - do not overwrite the skb->protocol in can_put_echo_skb()
>
> Can you split up the patch into the above mentioned aspects? More
> comments inline.
Yes. Will do.
>>
>> +struct sk_buff *alloc_canfd_skb(struct net_device *dev,
>> + struct canfd_frame **cfd)
>
> Stephane already posted a patch to add this function. I've already
> queued it. Please base you patch on linux-can-next/testing
>
Oh.
My patch is currently based on Davems net-tree, as this patch
http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=0ae89beb283a0db5980d1d4781c7d7be2f2810d6
is currently not in mainline nor in net-next nor in linux-can-next.
As the above patch clashes with the changes I did, I'll wait for Daves
net-next tree to be opened for development again before sending the patch set.
Btw. nice to see that there are no general problems besides the formal aspect.
Tnx,
Oliver
next prev parent reply other threads:[~2014-02-06 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 19:32 [PATCH can-next] Add CAN FD driver infrastructure Oliver Hartkopp
2014-02-06 11:41 ` Marc Kleine-Budde
2014-02-06 19:02 ` Oliver Hartkopp [this message]
2014-02-06 20:39 ` Marc Kleine-Budde
2014-02-12 11:15 ` Marc Kleine-Budde
2014-02-12 19:33 ` Oliver Hartkopp
2014-02-13 11:55 ` Marc Kleine-Budde
2014-02-14 20:58 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F3DC33.6080402@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).