From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Subject: Re: [PATCH v3 4/5] can: introduce the data bitrate configuration for CAN FD
Date: Fri, 21 Feb 2014 09:27:39 +0100 [thread overview]
Message-ID: <53070DFB.9080104@peak-system.com> (raw)
In-Reply-To: <1392481934-12569-4-git-send-email-socketcan@hartkopp.net>
Hi Oliver,
Only some nitpicking from my side, for the moment ...
Le 15/02/2014 17:32, Oliver Hartkopp a écrit :
>
> @@ -730,6 +757,10 @@ static size_t can_get_size(const struct net_device *dev)
> size += nla_total_size(sizeof(u32)); /* IFLA_CAN_RESTART_MS */
> if (priv->do_get_berr_counter) /* IFLA_CAN_BERR_COUNTER */
> size += nla_total_size(sizeof(struct can_berr_counter));
> + if (priv->data_bittiming.bitrate) /* IFLA_DATA_CAN_BITTIMING */
> + size += nla_total_size(sizeof(struct can_bittiming));
> + if (priv->data_bittiming_const) /* IFLA_DATA_CAN_BITTIMING_CONST */
> + size += nla_total_size(sizeof(struct can_bittiming_const));
>
> return size;
> }
IFLA_DATA_CAN_xxx should be changed into IFLA_CAN_DATA_xxx, in both
above eol comments.
Regards,
Stéphane
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next prev parent reply other threads:[~2014-02-21 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 16:32 [PATCH v3 1/5] can: preserve skbuff protocol in can_put_echo_skb Oliver Hartkopp
2014-02-15 16:32 ` [PATCH v3 2/5] can: netlink send bittiming data only when a bitrate is available Oliver Hartkopp
2014-02-15 16:32 ` [PATCH v3 3/5] can: provide a separate bittiming_const parameter to bittiming functions Oliver Hartkopp
2014-02-15 16:32 ` [PATCH v3 4/5] can: introduce the data bitrate configuration for CAN FD Oliver Hartkopp
2014-02-21 8:27 ` Stephane Grosjean [this message]
2014-02-15 16:32 ` [PATCH v3 5/5] can: allow to change the device mtu for CAN FD capable devices Oliver Hartkopp
2014-02-15 16:59 ` Marc Kleine-Budde
2014-02-15 17:00 ` Marc Kleine-Budde
2014-02-15 17:29 ` Oliver Hartkopp
2014-02-18 11:09 ` Marc Kleine-Budde
2014-02-18 13:08 ` Oliver Hartkopp
2014-02-19 18:25 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53070DFB.9080104@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).