From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: [PATCH RFC] Large file support (LFS) for can-utils
Date: Fri, 21 Feb 2014 21:21:04 +0100 [thread overview]
Message-ID: <5307B530.4010505@hartkopp.net> (raw)
Hi Uwe,
yesterday I tried to create a really big CAN logfile with
candump -l any
logging 9 CAN interfaces.
But unfortunately the length of the log file on my 32 bit i686 machine was
limited to 2147483647 == 0x7FFFFFFF == int32 max ...
I did some investigation and there's some kind of large file support (LFS) in
recent gnu libraries that allow 32 bit applications to create large files with
file length values > 0x7FFFFFFF when the filesystem supports it.
When applying the patch below my candump was able to create a large log file.
Alternatively
candump -L any > filename
did the job too as obviously 'cat' has large file support ;-)
What do you think about LFS?
Would this be the correct way to add the LFS support?
Regards,
Oliver
Not-really-signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
diff --git a/Makefile b/Makefile
index ab99746..a926177 100644
--- a/Makefile
+++ b/Makefile
@@ -45,6 +45,7 @@ MAKEFLAGS = -k
CFLAGS = -O2 -Wall -Wno-parentheses -Iinclude \
-fno-strict-aliasing \
+ -D_FILE_OFFSET_BITS=64 \
-DSO_RXQ_OVFL=40 \
-DPF_CAN=29 \
-DAF_CAN=PF_CAN
next reply other threads:[~2014-02-21 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 20:21 Oliver Hartkopp [this message]
2014-02-21 20:36 ` [PATCH RFC] Large file support (LFS) for can-utils Oliver Hartkopp
2014-02-21 21:37 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5307B530.4010505@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).