Re: [PATCH v4 7/7] can: add bittiming check at interface open for CAN FD

[Oliver Hartkopp <socketcan@hartkopp.net>]

On 21.02.2014 19:57, Oliver Hartkopp wrote:
> Additionally to have the second (data) bitrate available the data bitrate
> has to be greater or equal to the arbitration bitrate in CAN FD.
> 
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> ---
>  drivers/net/can/dev.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index d9f7281..9c3fb51 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -652,6 +652,14 @@ int open_candev(struct net_device *dev)
>  		return -EINVAL;
>  	}
>  
> +	/* For CAN FD the data bitrate has to be >= the arbitration bitrate */
> +	if ((priv->ctrlmode_supported & CAN_CTRLMODE_FD) &&

Oops.

This has to be the 'living'

	priv->ctrlmode

instead of the 'constant'

	priv->ctrlmode_supported

Will send an update when there's some more feedback or ACKs ...

Regards,
Oliver



> +	    (!priv->data_bittiming.tq || !priv->data_bittiming.bitrate ||
> +	     (priv->data_bittiming.bitrate < priv->bittiming.bitrate))) {
> +		netdev_err(dev, "incorrect/missing data bit-timing\n");
> +		return -EINVAL;
> +	}
> +
>  	/* Switch carrier on if device was stopped while in bus-off state */
>  	if (!netif_carrier_ok(dev))
>  		netif_carrier_on(dev);
>