Re: [PATCH 1/2] can: mcp251x: Move diagnostic messages to dev_dbg()

[Wolfgang Grandegger <wg@grandegger.com>]

On 02/22/2014 06:51 AM, Alexander Shiyan wrote:
> This patch moves diagnostic messages used for debugging purposes
> to dev_dbg().
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/net/can/mcp251x.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
> index cdb9808..56e38a6 100644
> --- a/drivers/net/can/mcp251x.c
> +++ b/drivers/net/can/mcp251x.c
> @@ -601,10 +601,10 @@ static int mcp251x_do_set_bittiming(struct net_device *net)
>  			  (bt->prop_seg - 1));
>  	mcp251x_write_bits(spi, CNF3, CNF3_PHSEG2_MASK,
>  			   (bt->phase_seg2 - 1));
> -	dev_info(&spi->dev, "CNF: 0x%02x 0x%02x 0x%02x\n",
> -		 mcp251x_read_reg(spi, CNF1),
> -		 mcp251x_read_reg(spi, CNF2),
> -		 mcp251x_read_reg(spi, CNF3));
> +	dev_dbg(&spi->dev, "CNF: 0x%02x 0x%02x 0x%02x\n",
> +		mcp251x_read_reg(spi, CNF1),
> +		mcp251x_read_reg(spi, CNF2),
> +		mcp251x_read_reg(spi, CNF3));
>  
>  	return 0;
>  }

It's common practice to show the bit-timing settings in the kernel log.
Therefore I prefer to keep this useful dev_info. If we change it, we
should update all other drivers as well.

> @@ -1155,7 +1155,7 @@ static int mcp251x_can_probe(struct spi_device *spi)
>  

>  	devm_can_led_init(net);
>  
> -	dev_info(&spi->dev, "probed\n");
> +	dev_dbg(&spi->dev, "probed\n");

This one could even be removed.

Wolfgang.