Re: MCP2515 DTS support

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2640 bytes --]

On 02/22/2014 08:46 PM, Lucas Zampar Bernardi wrote:
> Hi again,
> 
> 
> I found the causes of problem, and now I need to know if I was setting
> wrong structure or there are driver problem.
> I've had this modification on mcp251x.c:
> 
> static int mcp251x_can_probe(struct spi_device *spi)
> {
>     const struct of_device_id *of_id = of_match_device(mcp251x_of_match,
>                                &spi->dev);
>     struct mcp251x_platform_data *pdata = dev_get_platdata(&spi->dev);
>     struct net_device *net;
>     struct mcp251x_priv *priv;
>     int freq, ret = -ENODEV;
>     struct clk *clk;
> 
> 
>     clk = devm_clk_get(&spi->dev, NULL);
>     dev_dbg(&spi->dev, "MCP2515: clk = devm_clk_get(&spi->dev, NULL)");
>     if (IS_ERR(clk)) {
>         if (pdata)
>         {
>             freq = pdata->oscillator_frequency;
>         }
>         else
>         {
>>>        freq = 20 * 1000 * 1000;    // FORCE FREQUENCY to 20Mhz
>             //return PTR_ERR(clk);
>         }
>     } else {
>         dev_dbg(&spi->dev, "MCP2515: freq = clk_get_rate(clk);");
>         freq = clk_get_rate(clk);
>     }
> 
> 
> Then the driver start to run.
> 
> I think that the problem is about how to set a correct clock.
> 
> 
> I put on can node:
>                 can0: can@1 {
>                     compatible = "microchip,mcp2515";
>                     reg = <2>;
>                     spi-max-frequency = <5000000>;
>                     clocks = <&mcp251x_clock>;
>                     interrupt-parent = <&pioC>; /* MCP GPO Interrupt */
>                     interrupts = <12 0x2>;
>                 };
> 
> 
> 
> and my clocks node:
> 
>     clocks {
>         #address-cells = <1>;
>         #size-cells = <1>;
>         ranges;
> 
>         main_clock: clock@0 {
>             compatible = "atmel,osc", "fixed-clock";
>             clock-frequency = <12000000>;
>         };
> 
>         mcp251x_clock: mcp2515 {
>             compatible = "fixed-clock";
>             #clock-cells = <0>;
>             clock-frequency = <20000000>;
>         };
> 
> 
>     };
> 
> 
> So... How can we know if it's a DTS definition or a driver problem?

The driver looks good. I've put Alexander Shiyan, who contributed the DT
pachtes, on Cc. Maybe he can post the DT he used.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]