From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org,
Christian Pellegrin <chripell@evolware.org>,
Chris Elston <celston@katalix.com>
Subject: Re: [PATCH 1/2] can: mcp251x: Move diagnostic messages to dev_dbg()
Date: Wed, 26 Feb 2014 09:23:17 +0100 [thread overview]
Message-ID: <530DA475.3050609@pengutronix.de> (raw)
In-Reply-To: <1393388457.834211289@f330.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On 02/26/2014 05:20 AM, Alexander Shiyan wrote:
> Вторник, 25 февраля 2014, 21:41 +01:00 от Marc Kleine-Budde <mkl@pengutronix.de>:
>> On 02/23/2014 08:13 PM, Wolfgang Grandegger wrote:
>>> On 02/22/2014 06:51 AM, Alexander Shiyan wrote:
>>>> This patch moves diagnostic messages used for debugging purposes
>>>> to dev_dbg().
> ...
>>>> @@ -1155,7 +1155,7 @@ static int mcp251x_can_probe(struct spi_device *spi)
>>>>
>>>
>>>> devm_can_led_init(net);
>>>>
>>>> - dev_info(&spi->dev, "probed\n");
>>>> + dev_dbg(&spi->dev, "probed\n");
>>>
>>> This one could even be removed.
>>
>> +1
>
> Resend this one modified patch?
yes, please
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-02-26 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-22 5:51 [PATCH 1/2] can: mcp251x: Move diagnostic messages to dev_dbg() Alexander Shiyan
2014-02-22 5:51 ` [PATCH 2/2] can: mcp251x: Remove #ifdef CONFIG_PM_SLEEP Alexander Shiyan
2014-02-25 20:37 ` Marc Kleine-Budde
2014-02-23 19:13 ` [PATCH 1/2] can: mcp251x: Move diagnostic messages to dev_dbg() Wolfgang Grandegger
2014-02-25 20:41 ` Marc Kleine-Budde
2014-02-26 4:20 ` Alexander Shiyan
2014-02-26 8:23 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530DA475.3050609@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=celston@katalix.com \
--cc=chripell@evolware.org \
--cc=linux-can@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).