linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Lucas Zampar Bernardi <lucas.zampar@gmail.com>,
	Alexander Shiyan <shc_work@mail.ru>
Cc: linux-can@vger.kernel.org
Subject: Re: MCP2515 DTS support
Date: Wed, 26 Feb 2014 18:50:04 +0100	[thread overview]
Message-ID: <530E294C.4050209@pengutronix.de> (raw)
In-Reply-To: <530E262C.2040603@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]

On 02/26/2014 06:36 PM, Lucas Zampar Bernardi wrote:
> You are right Alexander!
> The CONFIG_COMMON_CLK hasn't enable!
> But for all SOC AT91_SAM9x5 still uses old clock style (AT91_USE_OLD_CLK):
> 
> config SOC_AT91SAM9X5
>         bool "AT91SAM9x5 family"
>         select HAVE_AT91_DBGU0
>         select HAVE_FB_ATMEL
>         select SOC_AT91SAM9
>         select AT91_USE_OLD_CLK
>         select HAVE_AT91_UTMI
>         select HAVE_AT91_SMD
>         select HAVE_AT91_USB_CLK
> 
> and one of dependencies for COMMON_CLK_AT91 is don't be AT91_USE_OLD_CLK
> 
> config COMMON_CLK_AT91
>         bool
>        default AT91_PMC_UNIT && USE_OF && !AT91_USE_OLD_CLK
>         select COMMON_CLK
> 
> config OLD_CLK_AT91
>         bool
>         default AT91_PMC_UNIT && AT91_USE_OLD_CLK
> 
> 
> 
> 
> Now came my question: Can I use CONFIG_COMMON_CLK without my ARCH
> support? If not, how we will support devices that need CONFIG_COMMON_CLK?

You probably have to wait for common clock support. However you can
still hook platform data to your spi device. For a mxs add this to
arch/arm/mach-mxs/mach-mxs.c:

static int abc_spi_notifier_call(struct notifier_block *nb,
					unsigned long event, void *data)
{
	struct device *dev = data;

	if (event == BUS_NOTIFY_BIND_DRIVER)
		if (strcmp(dev_name(dev), "spi32766.0") == 0)
			dev->platform_data = &abc_pdata;

	return NOTIFY_OK;
}

static struct notifier_block abc_spi_nb = {
	.notifier_call = abc_spi_notifier_call,
};

static void __init abc_post_init(void)
{
	bus_register_notifier(&spi_bus_type, &abc_spi_nb);
}

static void __init mxs_machine_init(void)
{

	of_platform_populate(NULL, of_default_bus_match_table,
			     mxs_auxdata_lookup, NULL);

	if (of_machine_is_compatible("123,abc"))
		abc_post_init();
}

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]

  reply	other threads:[~2014-02-26 17:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1445543c688.2748.cbaa067694a7e68fb76a213b35423fb5@gmail.com>
2014-02-21 16:26 ` MCP2515 DTS support Lucas Zampar Bernardi
2014-02-22 19:46   ` Lucas Zampar Bernardi
2014-02-25 21:35     ` Marc Kleine-Budde
2014-02-26  4:17       ` Alexander Shiyan
2014-02-26 13:12         ` Lucas Zampar Bernardi
2014-02-26 14:50           ` Alexander Shiyan
2014-02-26 17:36             ` Lucas Zampar Bernardi
2014-02-26 17:50               ` Marc Kleine-Budde [this message]
2014-02-26 18:01                 ` Alexander Shiyan
2014-02-26 18:17                   ` Lucas Zampar Bernardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530E294C.4050209@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=lucas.zampar@gmail.com \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).