From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Kleine-Budde Subject: Re: [PATCH v5 4/6] can: introduce the data bitrate configuration for CAN FD Date: Fri, 28 Feb 2014 13:52:15 +0100 Message-ID: <5310867F.8060503@pengutronix.de> References: <1393452662-3154-1-git-send-email-socketcan@hartkopp.net> <1393452662-3154-5-git-send-email-socketcan@hartkopp.net> <530EFAA0.4090000@pengutronix.de> <530F7E6A.4050307@hartkopp.net> <53106B6B.6040307@pengutronix.de> <53107F29.1080109@hartkopp.net> <53108165.5050606@pengutronix.de> <53108210.6070700@hartkopp.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QSTM2CdOgxKaC9aAICwjJMcSCq3AcQwxG" Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:34047 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbaB1MwU (ORCPT ); Fri, 28 Feb 2014 07:52:20 -0500 In-Reply-To: <53108210.6070700@hartkopp.net> Sender: linux-can-owner@vger.kernel.org List-ID: To: Oliver Hartkopp , linux-can@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QSTM2CdOgxKaC9aAICwjJMcSCq3AcQwxG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/28/2014 01:33 PM, Oliver Hartkopp wrote: >=20 >=20 > On 28.02.2014 13:30, Marc Kleine-Budde wrote: >> On 02/28/2014 01:20 PM, Oliver Hartkopp wrote: >>> >>> >>> On 28.02.2014 11:56, Marc Kleine-Budde wrote: >>>> On 02/27/2014 07:05 PM, Oliver Hartkopp wrote: >>>>> On 27.02.2014 09:43, Marc Kleine-Budde wrote: >>>>> >>>>>>> + if (priv->do_set_data_bittiming) { >>> >>> >>>> >>>>> The bitrate is always set via do_set[_data]_bittiming() when the in= terface is >>>>> down - and *not* during the open process. >>>> >>>> No, not _always_. The flexcan and at91 drivers (maybe others, too) w= rite >>>> the values during open(). >>> >>> flexcan does not assign priv->do_set_bittiming() and does the bitrate= setting >>> at open time. >>> >>> Thats ok too. >>> >>> This is up to the driver, whether do_set[_data]_bittiming() is assign= ed and >>> when the stuff in the bitrate structures is set into the registers. >>> >>> I don't understand your problem. >> >> A new do_set_data_bittiming() callback is not needed, as it's better d= o >> set the data and "normal" bit timing registers during open(). >=20 > With this argumentation do_set_bittiming() has to be removed too. >=20 > Is this your intention? Yes. But it's in many drivers so let's keep it, for now. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --QSTM2CdOgxKaC9aAICwjJMcSCq3AcQwxG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlMQhn8ACgkQjTAFq1RaXHPTGgCfUqS3/4ID1JipFGYTVgn6/sZB jSYAn2Dt4zK7ivH7wXEkYqGlRAlJJoPN =0nJI -----END PGP SIGNATURE----- --QSTM2CdOgxKaC9aAICwjJMcSCq3AcQwxG--