From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [PATCH v8 4/7] can: provide a separate bittiming_const parameter to bittiming functions
Date: Fri, 28 Feb 2014 16:15:52 +0100 [thread overview]
Message-ID: <5310A828.3030507@hartkopp.net> (raw)
In-Reply-To: <1393593549-23072-5-git-send-email-socketcan@hartkopp.net>
Hey Marc,
i've just seen a whitespace issue here:
On 28.02.2014 14:19, Oliver Hartkopp wrote:
> - return 0;
> + if (!bt->tq && bt->bitrate)
> + err = can_calc_bittiming(dev, bt, btc);
> + else if (bt->tq && !bt->bitrate)
> + err = can_fixup_bittiming(dev, bt, btc);
> + else
> + err = -EINVAL;
> +
> + return err;
Should I send a v9 or what's the best way for you?
Regards,
Oliver
next prev parent reply other threads:[~2014-02-28 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 13:19 [PATCH v8 0/7] Add CAN FD infrastructure for CAN driver Oliver Hartkopp
2014-02-28 13:19 ` [PATCH v8 1/7] can: preserve skbuff protocol in can_put_echo_skb Oliver Hartkopp
2014-02-28 13:19 ` [PATCH v8 2/7] can: only send bitrate data via netlink when available Oliver Hartkopp
2014-02-28 13:19 ` [PATCH v8 3/7] can: move sanity check for bitrate and tq into can_get_bittiming Oliver Hartkopp
2014-02-28 13:19 ` [PATCH v8 4/7] can: provide a separate bittiming_const parameter to bittiming functions Oliver Hartkopp
2014-02-28 15:15 ` Oliver Hartkopp [this message]
2014-02-28 15:16 ` Marc Kleine-Budde
2014-02-28 13:19 ` [PATCH v8 5/7] can: introduce the data bitrate configuration for CAN FD Oliver Hartkopp
2014-02-28 13:19 ` [PATCH v8 6/7] can: allow to change the device mtu for CAN FD capable devices Oliver Hartkopp
2014-02-28 13:19 ` [PATCH v8 7/7] can: add bittiming check at interface open for CAN FD Oliver Hartkopp
2014-02-28 15:18 ` [PATCH v8 0/7] Add CAN FD infrastructure for CAN driver Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310A828.3030507@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).