From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCH v10 1/7] Add CAN FD infrastructure for CAN driver
Date: Tue, 04 Mar 2014 22:22:28 +0100 [thread overview]
Message-ID: <53164414.2070903@hartkopp.net> (raw)
In-Reply-To: <1393965855-3408-1-git-send-email-mkl@pengutronix.de>
On 04.03.2014 21:44, Marc Kleine-Budde wrote:
> Picking up Oliver's patches.
>
> I've added Stephane's Acked-by to all patches.
>
> Changes since v9:
> - 3/7 + 4/7
> I moved the simplified "if" in can_get_bittiming() from 4/7 into 3/7,
> so the more complicated if is not introduced in the first place.
ok.
> - 5/7
> In can_changelink(), when setting the data bittining, I removed the call to
> priv->do_set_data_bittiming().
I think the call to priv->do_set_data_bittiming() has to remain here to be
consistent to priv->do_set_bittiming() in the same function.
When priv->do_set_[data_]bittiming() is to be removed in the future it should
be removed for both functions in the same way to prevent confusion.
> Further I moved the new "if (data[IFLA_CAN_DATA_BITTIMING])" at the bottom,
> so that all "if"s are sorted by "IFLA_".
?? You are moving the "if (data[IFLA_CAN_DATA_BITTIMING])" here and then you
move it in 6/7 again. %-)
> - 6/7
> can_change_mtu(): fix indention after "default" in "switch"
ok.
Tnx,
Oliver
next prev parent reply other threads:[~2014-03-04 21:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:44 [PATCH v10 1/7] Add CAN FD infrastructure for CAN driver Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 1/7] can: preserve skbuff protocol in can_put_echo_skb Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 2/7] can: only send bitrate data via netlink when available Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 3/7] can: move sanity check for bitrate and tq into can_get_bittiming Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 4/7] can: provide a separate bittiming_const parameter to bittiming functions Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 5/7] can: introduce the data bitrate configuration for CAN FD Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 6/7] can: allow to change the device mtu for CAN FD capable devices Marc Kleine-Budde
2014-03-04 20:44 ` [PATCH v10 7/7] can: add bittiming check at interface open for CAN FD Marc Kleine-Budde
2014-03-04 21:22 ` Oliver Hartkopp [this message]
2014-03-04 21:32 ` [PATCH v10 1/7] Add CAN FD infrastructure for CAN driver Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53164414.2070903@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).