From: Stefano Babic <sbabic@denx.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Cc: Stefano Babic <sbabic@denx.de>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v2 1/3] Add documentation for SPI to CAN driver
Date: Wed, 26 Mar 2014 09:07:00 +0100 [thread overview]
Message-ID: <53328AA4.9070507@denx.de> (raw)
In-Reply-To: <5331C773.9070505@hartkopp.net>
Hi Oliver,
On 25/03/2014 19:14, Oliver Hartkopp wrote:
> Please check the patch with checkpatch.pl ...
>
> There are thousands of lines > 80 chars :-)
>
Well, checkpatch ran over the patches:
scripts/checkpatch.pl 0001-Add-documentation-for-SPI-to-CAN-driver.patch
total: 0 errors, 0 warnings, 707 lines checked
0001-Add-documentation-for-SPI-to-CAN-driver.patch has no obvious style
problems and is ready for submission.
Anyway, the patch contains tons of long lines. I will check tjem
manually before submitting and fix them.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
next prev parent reply other threads:[~2014-03-26 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 14:30 [PATCH v2 0/3] Adding support for CAN busses via SPI interface Stefano Babic
2014-03-25 14:30 ` [PATCH v2 1/3] Add documentation for SPI to CAN driver Stefano Babic
2014-03-25 18:14 ` Oliver Hartkopp
2014-03-26 8:07 ` Stefano Babic [this message]
2014-03-25 14:30 ` [PATCH v2 2/3] CAN: moved SPI drivers into a separate directory Stefano Babic
2014-03-25 18:56 ` Oliver Hartkopp
2014-04-01 21:08 ` Marc Kleine-Budde
2014-03-25 14:30 ` [PATCH v2 3/3] CAN: CAN driver to support multiple CAN bus on SPI interface Stefano Babic
2014-03-25 18:54 ` Oliver Hartkopp
2014-03-26 9:01 ` Stefano Babic
2014-04-06 15:20 ` Wolfgang Grandegger
2014-04-06 19:01 ` Oliver Hartkopp
2014-04-06 19:22 ` Wolfgang Grandegger
2014-04-06 19:42 ` Oliver Hartkopp
2014-04-07 8:29 ` Stefano Babic
2014-04-07 9:34 ` Wolfgang Grandegger
2014-04-07 10:24 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53328AA4.9070507@denx.de \
--to=sbabic@denx.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).