From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Wolfgang Grandegger <wg@grandegger.com>, linux-can@vger.kernel.org
Subject: Re: [PATCH 4/4] can: mcp251x: Remove unnecessary power disabling
Date: Wed, 02 Apr 2014 09:05:55 +0200 [thread overview]
Message-ID: <533BB6D3.401@pengutronix.de> (raw)
In-Reply-To: <1396419467.957204803@f401.i.mail.ru>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On 04/02/2014 08:17 AM, Alexander Shiyan wrote:
> Tue, 01 Apr 2014 22:36:27 +0200 от Marc Kleine-Budde <mkl@pengutronix.de>:
>> On 03/28/2014 11:14 AM, Alexander Shiyan wrote:
>>> This patch remove unnecessary power disabling on error and on module
>>> exit since this is already done by regulator API.
>>
>> Oh really? Can you point me to the commit in mainline which introduces
>> this change? As far as I understand devm just callss
>> devm_regulator_release(), which calls regulator_put().
>
> It seems that you are right. I thought that the regulator is switched off when
> the usage count reaches zero, but it is not.
> In this case, please drop the [4/4] patch.
Will do, I'll push the remaining three patches to the can-next as soon
as you give me your okay for the v2 series.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
next prev parent reply other threads:[~2014-04-02 7:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 10:14 [PATCH 1/4] can: mcp251x: Check return value of spi_setup() Alexander Shiyan
2014-03-28 10:14 ` [PATCH 2/4] can: mcp251x: Improve mcp251x_hw_reset() Alexander Shiyan
2014-04-01 20:47 ` Marc Kleine-Budde
2014-03-28 10:14 ` [PATCH 3/4] can: mcp251x: Improve mcp251x_hw_probe() Alexander Shiyan
2014-04-01 20:46 ` Marc Kleine-Budde
2014-03-28 10:14 ` [PATCH 4/4] can: mcp251x: Remove unnecessary power disabling Alexander Shiyan
2014-04-01 20:36 ` Marc Kleine-Budde
2014-04-02 6:17 ` Alexander Shiyan
2014-04-02 7:05 ` Marc Kleine-Budde [this message]
2014-04-01 11:56 ` [PATCH 1/4] can: mcp251x: Check return value of spi_setup() Marc Kleine-Budde
2014-04-01 12:47 ` Alexander Shiyan
2014-04-01 12:49 ` Marc Kleine-Budde
2014-04-01 12:54 ` Alexander Shiyan
2014-04-01 20:40 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533BB6D3.401@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=shc_work@mail.ru \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).