From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Thomas Gleixner <tglx@linutronix.de>,
linux-can <linux-can@vger.kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: Re: [patch 10/10] can: c_can : Disable rx split as workaround
Date: Fri, 04 Apr 2014 19:41:28 +0200 [thread overview]
Message-ID: <533EEEC8.3090905@hartkopp.net> (raw)
In-Reply-To: <20140404134858.173427806@linutronix.de>
-------- Original Message --------
Subject: [patch 10/10] can: c_can : Disable rx split as workaround
(..)
+config CAN_C_CAN_NO_RX_SPLIT
+ bool "Disable RX Split buffer"
+ ---help---
+ RX Split buffer prevents packet reordering but can cause packet
+ loss. Select the less of the two evils.
+
Can you try to use something more understandable for the Kconfig option?
AFAICS there are the options:
1. Frames are in order but may get lost.
2. Frames do not get lost but may be disordered.
No user/kernel builder knows about "rx split buffers" ...
What about
+config CAN_C_CAN_STRICT_FRAME_ORDERING
+ bool "Force a strict RX CAN frame order (may cause frame loss)"
+ ---help---
+ The RX split buffer prevents packet reordering but can cause packet
+ loss. Only enable this option when you accept to lose CAN frames
+ in favor of getting the received CAN frames in the correct order.
+
Regards,
Oliver
ps. Your patches are attached in my mail client, which makes it hard to
comment the code inline.
next prev parent reply other threads:[~2014-04-04 17:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 15:24 [patch 00/10] can: c_can: Another pile of fixes and improvements Thomas Gleixner
2014-04-04 15:24 ` [patch 01/10] can: c_can: Fix startup logic Thomas Gleixner
2014-04-04 15:24 ` [patch 02/10] can: c_can: Make bus off interrupt disable logic work Thomas Gleixner
2014-04-04 15:24 ` [patch 03/10] can: c_can: Do not access skb after net_receive_skb() Thomas Gleixner
2014-04-04 15:24 ` [patch 04/10] can: c_can: Handle state change correctly Thomas Gleixner
2014-04-04 15:24 ` [patch 05/10] can: c_can: Fix berr reporting Thomas Gleixner
2014-04-04 15:24 ` [patch 06/10] can: c_can: Always update error stats Thomas Gleixner
2014-04-04 15:24 ` [patch 07/10] can: c_can: Simplify buffer reenabling Thomas Gleixner
2014-04-04 16:14 ` Oliver Hartkopp
2014-04-04 16:33 ` Thomas Gleixner
2014-04-04 15:24 ` [patch 08/10] can: c_can: Avoid status register update for D_CAN Thomas Gleixner
2014-04-04 15:24 ` [patch 09/10] can: c_can: Get rid of pointless interrupts Thomas Gleixner
2014-04-04 15:24 ` [patch 10/10] can: c_can : Disable rx split as workaround Thomas Gleixner
2014-04-04 16:17 ` Mark
2014-04-04 16:38 ` Thomas Gleixner
2014-04-05 18:57 ` Thomas Gleixner
2014-04-04 16:43 ` Thomas Gleixner
2014-04-05 18:56 ` Thomas Gleixner
2014-04-05 19:38 ` Wolfgang Grandegger
2014-04-05 19:42 ` Wolfgang Grandegger
2014-04-05 19:48 ` Thomas Gleixner
2014-04-05 19:53 ` Wolfgang Grandegger
2014-04-04 17:41 ` Oliver Hartkopp [this message]
2014-04-04 18:55 ` Thomas Gleixner
2014-04-04 19:51 ` Thomas Gleixner
2014-04-04 20:54 ` [patch 10/10 V2] can: c_can: Disable rx buffer split to prevent packet loss Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533EEEC8.3090905@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=tglx@linutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).