From: Wolfgang Grandegger <wg@grandegger.com>
To: Thomas Gleixner <tglx@linutronix.de>, Mark <mark5@del-llc.com>
Cc: linux-can <linux-can@vger.kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: Re: [patch 10/10] can: c_can : Disable rx split as workaround
Date: Sat, 05 Apr 2014 21:42:02 +0200 [thread overview]
Message-ID: <53405C8A.3030702@grandegger.com> (raw)
In-Reply-To: <53405BCC.7060701@grandegger.com>
On 04/05/2014 09:38 PM, Wolfgang Grandegger wrote:
> On 04/05/2014 08:56 PM, Thomas Gleixner wrote:
>> On Fri, 4 Apr 2014, Mark wrote:
>>
>>> Thomas: a few comments on my experience with the CAN driver:
>>>
>>> I think I agree with your approach -- I had the same problem losing a packet
>>> when running through the clearing of the newdat flags.
>>>
>>> About a month ago, I re-wrote pch_can.c (before I discovered this mailing
>>> list) and got it to work successfully sending / receiving CAN data at 1 MBIT
>>
>> Wow, that's amazing.
>
> We realized late that the pch_can manual [1] is an exact copy of the
> c_can manual just with different register names (and without mentioning
> c_can at all). Also the initial author didn't mentioning it. Maybe he
> did not even know.
>
>> That driver is just a variant of c_can.c with quite some of the same
>> bugs and some different ones.
>
> It's worse :(.
>
>> We really should switch that over to c_can.c and get rid of it.
>
> See http://news.gmane.org/gmane.linux.can. Should we remove pch_can
> immediately? Or labeling it deprecated first.
I mean the link http://article.gmane.org/gmane.linux.can/5440
Wolfgang
next prev parent reply other threads:[~2014-04-05 19:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 15:24 [patch 00/10] can: c_can: Another pile of fixes and improvements Thomas Gleixner
2014-04-04 15:24 ` [patch 01/10] can: c_can: Fix startup logic Thomas Gleixner
2014-04-04 15:24 ` [patch 03/10] can: c_can: Do not access skb after net_receive_skb() Thomas Gleixner
2014-04-04 15:24 ` [patch 02/10] can: c_can: Make bus off interrupt disable logic work Thomas Gleixner
2014-04-04 15:24 ` [patch 04/10] can: c_can: Handle state change correctly Thomas Gleixner
2014-04-04 15:24 ` [patch 05/10] can: c_can: Fix berr reporting Thomas Gleixner
2014-04-04 15:24 ` [patch 06/10] can: c_can: Always update error stats Thomas Gleixner
2014-04-04 15:24 ` [patch 07/10] can: c_can: Simplify buffer reenabling Thomas Gleixner
2014-04-04 16:14 ` Oliver Hartkopp
2014-04-04 16:33 ` Thomas Gleixner
2014-04-04 15:24 ` [patch 09/10] can: c_can: Get rid of pointless interrupts Thomas Gleixner
2014-04-04 15:24 ` [patch 08/10] can: c_can: Avoid status register update for D_CAN Thomas Gleixner
2014-04-04 15:24 ` [patch 10/10] can: c_can : Disable rx split as workaround Thomas Gleixner
2014-04-04 16:17 ` Mark
2014-04-04 16:38 ` Thomas Gleixner
2014-04-05 18:57 ` Thomas Gleixner
2014-04-04 16:43 ` Thomas Gleixner
2014-04-05 18:56 ` Thomas Gleixner
2014-04-05 19:38 ` Wolfgang Grandegger
2014-04-05 19:42 ` Wolfgang Grandegger [this message]
2014-04-05 19:48 ` Thomas Gleixner
2014-04-05 19:53 ` Wolfgang Grandegger
2014-04-04 17:41 ` Oliver Hartkopp
2014-04-04 18:55 ` Thomas Gleixner
2014-04-04 19:51 ` Thomas Gleixner
2014-04-04 20:54 ` [patch 10/10 V2] can: c_can: Disable rx buffer split to prevent packet loss Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53405C8A.3030702@grandegger.com \
--to=wg@grandegger.com \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-can@vger.kernel.org \
--cc=mark5@del-llc.com \
--cc=mkl@pengutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).