Re: [PATCH] c_can: Add support for eg20t (pch_can)

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On 04/07/2014 05:24 PM, Thomas Gleixner wrote:
> On Mon, 7 Apr 2014, Alexander Stein wrote:
>> On Monday 07 April 2014 15:31:20, Thomas Gleixner wrote:
>>> What other patches do you have applied?
>>
>> I have shrinked them a bit to the absolute necessity. In general
>> these are patches for the current hardware to make them working.
> 
>> 53b385c37e4eb155cf9d515913ddf76750e2ac24 c_can: Add support for eg20t (pch_can)
> 
> I can't see anything whats wrong with that one.
> 
> Can you check, whether the following check in c_can_read_objects()
> 
>                if (!(ctrl & IF_MCONT_NEWDAT))
>                         continue;

On TI's D_CAN with all your patches applied and the split buffer
approach active, I haven't this trigger in a ~4h test run. Athough there
are regularly missing frames, apart from this, they are in the correct
order.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]