Re: Problem with Eurotech COM1273 Dual Channel CAN PC104 Module.

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]

On 04/15/2014 02:00 PM, Oliver Hartkopp wrote:
> As I wrote in the other thread:
> 
>> The command i am executing is 
>> modprobe sja1000_isa port=0x200,0x204 irq=10,11 indirect=1 
> 
> The parameters for each interface are given separately

The indirect mode is racy, btw....

> static u8 sja1000_isa_port_read_reg_indirect(const struct sja1000_priv *priv,
>                                              int reg)
> {
>         unsigned long base = (unsigned long)priv->reg_base;
> 
>         outb(reg, base);
>         return inb(base + 1);
> }
> 
> static void sja1000_isa_port_write_reg_indirect(const struct sja1000_priv *priv,
>                                                 int reg, u8 val)
> {
>         unsigned long base = (unsigned long)priv->reg_base;
> 
>         outb(reg, base);
>         outb(val, base + 1);
> }

We need locks.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]