From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Wolfram Sang <wsa@the-dreams.de>, linux-can@vger.kernel.org
Cc: Chen Gang <gang.chen@asianux.com>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH] net: can: c_can: use proper type for 'instance'
Date: Thu, 17 Apr 2014 21:22:41 +0200 [thread overview]
Message-ID: <53502A01.10908@pengutronix.de> (raw)
In-Reply-To: <1397725047-7833-1-git-send-email-wsa@the-dreams.de>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On 04/17/2014 10:57 AM, Wolfram Sang wrote:
> From: Wolfram Sang <wsa@sang-engineering.com>
>
> Commit 6439fbce1075 (can: c_can: fix error checking of priv->instance in
> probe()) found the warning but applied a suboptimal solution. Since, both
> pdev->id and of_alias_get_id() return integers, it makes sense to convert the
> variable to an integer and avoid the cast.
>
> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
Applied to can/master.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]
prev parent reply other threads:[~2014-04-17 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 8:57 [PATCH] net: can: c_can: use proper type for 'instance' Wolfram Sang
2014-04-17 19:22 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53502A01.10908@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=gang.chen@asianux.com \
--cc=linux-can@vger.kernel.org \
--cc=wg@grandegger.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).