Re: [PATCH v2] c_can: Add support for eg20t (pch_can)

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

On 04/17/2014 11:18 PM, Thomas Gleixner wrote:
> On Thu, 17 Apr 2014, Marc Kleine-Budde wrote:
> 
>> On 04/07/2014 08:52 AM, Alexander Stein wrote:
>>> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
>> [..]
>>
>>> +static void c_can_pci_reset_pch(const struct c_can_priv *priv, bool enable)
>>> +{
>>> +	if (enable) {
>>> +		u32 __iomem *addr = priv->base + PCH_PCI_SOFT_RESET;
>>> +
>>> +		/* write to sw reset register */
>>> +		iowrite32(1, addr);
>>
>> Do we need to wait for something here?
> 
> No. It's activating the "reset line" for that IP block. As long as the
> bit is set the IP is effectivly in HW reset state. Releasing the reset
> brings it back to operation. iowrite32() is serialized by itself, so
> no extra work required.

Thanks Thomas.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]